You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by gp...@apache.org on 2009/11/27 22:10:20 UTC
svn commit: r885017 - in
/myfaces/extensions/validator/branches/branch_for_jsf_2_0:
core/src/main/java/org/apache/myfaces/extensions/validator/core/renderkit/
validation-modules/bean-validation/src/main/java/org/apache/myfaces/extensions/validator/bean...
Author: gpetracek
Date: Fri Nov 27 21:10:20 2009
New Revision: 885017
URL: http://svn.apache.org/viewvc?rev=885017&view=rev
Log:
minor changes
Modified:
myfaces/extensions/validator/branches/branch_for_jsf_2_0/core/src/main/java/org/apache/myfaces/extensions/validator/core/renderkit/ExtValRendererProxy.java
myfaces/extensions/validator/branches/branch_for_jsf_2_0/validation-modules/bean-validation/src/main/java/org/apache/myfaces/extensions/validator/beanval/util/BeanValidationUtils.java
Modified: myfaces/extensions/validator/branches/branch_for_jsf_2_0/core/src/main/java/org/apache/myfaces/extensions/validator/core/renderkit/ExtValRendererProxy.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/validator/branches/branch_for_jsf_2_0/core/src/main/java/org/apache/myfaces/extensions/validator/core/renderkit/ExtValRendererProxy.java?rev=885017&r1=885016&r2=885017&view=diff
==============================================================================
--- myfaces/extensions/validator/branches/branch_for_jsf_2_0/core/src/main/java/org/apache/myfaces/extensions/validator/core/renderkit/ExtValRendererProxy.java (original)
+++ myfaces/extensions/validator/branches/branch_for_jsf_2_0/core/src/main/java/org/apache/myfaces/extensions/validator/core/renderkit/ExtValRendererProxy.java Fri Nov 27 21:10:20 2009
@@ -22,6 +22,7 @@
import org.apache.myfaces.extensions.validator.internal.UsageInformation;
import org.apache.myfaces.extensions.validator.core.storage.RendererProxyStorageEntry;
import org.apache.myfaces.extensions.validator.core.storage.RendererProxyStorage;
+import org.apache.myfaces.extensions.validator.core.ProjectStage;
import org.apache.myfaces.extensions.validator.util.ExtValUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -30,6 +31,7 @@
import javax.faces.render.Renderer;
import javax.faces.component.UIComponent;
import javax.faces.convert.ConverterException;
+import javax.faces.application.FacesMessage;
import java.io.IOException;
/**
@@ -77,10 +79,7 @@
}
else
{
- if(logger.isTraceEnabled())
- {
- logger.trace("double call of method 'decode' filtered");
- }
+ tryToCreateMessage("decode");
}
}
@@ -110,10 +109,7 @@
}
else
{
- if(logger.isTraceEnabled())
- {
- logger.trace("double call of method 'encodeBegin' filtered");
- }
+ tryToCreateMessage("encodeBegin");
}
}
@@ -144,10 +140,7 @@
}
else
{
- if(logger.isTraceEnabled())
- {
- logger.trace("double call of method 'encodeChildren' filtered");
- }
+ tryToCreateMessage("encodeChildren");
}
}
@@ -178,10 +171,7 @@
}
else
{
- if(logger.isTraceEnabled())
- {
- logger.trace("double call of method 'encodeEnd' filtered");
- }
+ tryToCreateMessage("encodeEnd");
}
}
@@ -233,10 +223,7 @@
}
else
{
- if(logger.isTraceEnabled())
- {
- logger.trace("double call of method 'getConvertedValue' filtered");
- }
+ tryToCreateMessage("getConvertedValue");
}
return entry.getConvertedValue();
}
@@ -274,4 +261,29 @@
//reset component proxy mapping
ExtValUtils.resetStorage(RendererProxyStorage.class, RendererProxyStorage.class.getName());
}
+
+ private void tryToCreateMessage(String methodName)
+ {
+ if(ProjectStage.is(ProjectStage.Development))
+ {
+ String message = "double call of " + this.wrapped.getClass().getName() + "#" + methodName + " filtered. " +
+ "this optimization might lead to incompatibilities with some component libs. " +
+ "in such a case use the support module for the component lib or use: " +
+ "ExtValContext.getContext().addGlobalProperty(ExtValRendererProxy.KEY, null); " +
+ "in a startup listener";
+
+ FacesContext.getCurrentInstance()
+ .addMessage(null, ExtValUtils.createFacesMessage(FacesMessage.SEVERITY_WARN, message, message));
+
+ if(logger.isWarnEnabled())
+ {
+ logger.warn(message);
+ }
+ }
+
+ if(logger.isDebugEnabled())
+ {
+ logger.debug("turn on the development mode for further information, if something is displayed wrong.");
+ }
+ }
}
Modified: myfaces/extensions/validator/branches/branch_for_jsf_2_0/validation-modules/bean-validation/src/main/java/org/apache/myfaces/extensions/validator/beanval/util/BeanValidationUtils.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/validator/branches/branch_for_jsf_2_0/validation-modules/bean-validation/src/main/java/org/apache/myfaces/extensions/validator/beanval/util/BeanValidationUtils.java?rev=885017&r1=885016&r2=885017&view=diff
==============================================================================
--- myfaces/extensions/validator/branches/branch_for_jsf_2_0/validation-modules/bean-validation/src/main/java/org/apache/myfaces/extensions/validator/beanval/util/BeanValidationUtils.java (original)
+++ myfaces/extensions/validator/branches/branch_for_jsf_2_0/validation-modules/bean-validation/src/main/java/org/apache/myfaces/extensions/validator/beanval/util/BeanValidationUtils.java Fri Nov 27 21:10:20 2009
@@ -225,7 +225,6 @@
.addMessage(null, ExtValUtils.createFacesMessage(FacesMessage.SEVERITY_WARN, message, message));
}
-
if(LOGGER.isWarnEnabled())
{
LOGGER.warn(message);