You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/11 02:05:53 UTC

[GitHub] [apisix-dashboard] LiteSun commented on a diff in pull request #2573: fix: drawer components delete plugin not working

LiteSun commented on code in PR #2573:
URL: https://github.com/apache/apisix-dashboard/pull/2573#discussion_r943045805


##########
web/cypress/integration/plugin/create-delete-in-drawer-plugin.spec.js:
##########
@@ -109,4 +109,42 @@ context('Delete Plugin List with the Drawer', () => {
     });
     cy.get(selector.empty).should('be.visible');
   });
+
+  it('should delete the plugin with the drawer in the list of plugins', function () {
+    cy.visit('/plugin/list');
+    cy.get(selector.refresh).click();
+    cy.contains('Enable').click();
+
+    cy.contains(data.basicAuthPlugin)
+      .parents(selector.pluginCardBordered)
+      .within(() => {
+        cy.get('button').click({
+          force: true,
+        });
+      });
+    cy.get(selector.drawer)
+      .should('be.visible')
+      .within(() => {
+        cy.get(selector.disabledSwitcher).click();
+        cy.get(selector.checkedSwitcher).should('exist');
+      });
+    cy.contains('button', 'Submit').click();
+
+    cy.contains(data.basicAuthPlugin)
+      .parents(selector.pluginCardBordered)
+      .within(() => {
+        cy.get('button').click({
+          force: true,

Review Comment:
   Perhaps it would be better to use a more precise selector?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org