You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by r7raul1984 <gi...@git.apache.org> on 2017/01/20 00:01:30 UTC
[GitHub] eagle pull request #787: [MINOR] Change default-rack to /default-rack
GitHub user r7raul1984 opened a pull request:
https://github.com/apache/eagle/pull/787
[MINOR] Change default-rack to /default-rack
- Change default-rack to /default-rack
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1haodian/eagle DEFAULT-RACK
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/eagle/pull/787.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #787
----
commit a1379c7016a32817775d4879f62efd313bb79af1
Author: r7raul1984 <ta...@yhd.com>
Date: 2017-01-20T00:00:06Z
[MINOR] Change default-rack to /default-rack
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #787: [MINOR] Change default-rack to /default-rack
Posted by r7raul1984 <gi...@git.apache.org>.
Github user r7raul1984 commented on the issue:
https://github.com/apache/eagle/pull/787
@qingwen220 Because ClusterNodeAPITopologyRackResolver use "/default-rack" .I think it will issue some problem when you complete EAGLE-876.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #787: [MINOR] Change default-rack to /default-rack
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the issue:
https://github.com/apache/eagle/pull/787
It do not matter. The node with a new rack info will replace the old one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #787: [MINOR] Change default-rack to /default-rack
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the issue:
https://github.com/apache/eagle/pull/787
At the initial design, we prefer to extract the 'exact rack info', for example, '/rack-45' -> 'rack-45', '/' will be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #787: [MINOR] Change default-rack to /default-rack
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/eagle/pull/787
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #787: [MINOR] Change default-rack to /default-rack
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the issue:
https://github.com/apache/eagle/pull/787
Why do you need this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---