[GitHub] [iceberg] ddrinka commented on a diff in pull request #6123: Python: Support creating a DateLiteral from a date (#6120)

[GitBox <gi...@apache.org>]

ddrinka commented on code in PR #6123:
URL: https://github.com/apache/iceberg/pull/6123#discussion_r1014897183


##########
python/pyiceberg/utils/datetime.py:
##########
@@ -47,11 +47,16 @@ def micros_to_time(micros: int) -> time:
     return time(hour=hours, minute=minutes, second=seconds, microsecond=microseconds)
 
 
-def date_to_days(date_str: str) -> int:
+def date_str_to_days(date_str: str) -> int:

Review Comment:
   My thought process was that this API is still pre 1.0 and the existing name was misleading, so better to improve it now.  I have no preference either way though, so happy to adjust.  I'm not sure how to support both with the same name though?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org