You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/25 16:28:12 UTC
[GitHub] [spark] sarutak opened a new pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
sarutak opened a new pull request #31964:
URL: https://github.com/apache/spark/pull/31964
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR fixes an issue that `quoteIfNeeded` quotes a name only if it contains `.` or ``` ` ```.
This method should quotes it if it contains non-word characters.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
It's a potential bug.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31964:
URL: https://github.com/apache/spark/pull/31964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-855834147
@sarutak
I ran git bisect and it seems, that this PR introduced a regression:
```
test("SPARK-XXXXX: special char in column name") {
withTempDir { dir =>
val file = new File(dir, "output.csv")
val fileContent =
"""
|a / b
|val1
|""".stripMargin
FileUtils.writeStringToFile(file, fileContent, StandardCharsets.UTF_8)
spark.read
.option("header", true)
.csv(file.toString)
.where(col("a / b").isNotNull)
.show()
}
}
```
fails with
```
[info] - SPARK-XXXXX: special char in column name *** FAILED *** (2 seconds, 547 milliseconds)
[info] org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 1.0 failed 1 times, most recent failure: Lost task 0.0 in stage 1.0 (TID 1) (archlinux executor driver): java.lang.IllegalArgumentException: `a / b` does not exist. Available: a / b
[info] at org.apache.spark.sql.types.StructType.$anonfun$fieldIndex$1(StructType.scala:306)
[info] at scala.collection.immutable.Map$Map1.getOrElse(Map.scala:119)
[info] at org.apache.spark.sql.types.StructType.fieldIndex(StructType.scala:305)
[info] at org.apache.spark.sql.catalyst.OrderedFilters.$anonfun$predicates$4(OrderedFilters.scala:61)
[info] at org.apache.spark.sql.catalyst.OrderedFilters.$anonfun$predicates$4$adapted(OrderedFilters.scala:61)
[info] at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:238)
[info] at scala.collection.IndexedSeqOptimized.foreach(IndexedSeqOptimized.scala:36)
[info] at scala.collection.IndexedSeqOptimized.foreach$(IndexedSeqOptimized.scala:33)
[info] at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:198)
[info] at scala.collection.TraversableLike.map(TraversableLike.scala:238)
[info] at scala.collection.TraversableLike.map$(TraversableLike.scala:231)
[info] at scala.collection.mutable.ArrayOps$ofRef.map(ArrayOps.scala:198)
[info] at org.apache.spark.sql.catalyst.OrderedFilters.$anonfun$predicates$3(OrderedFilters.scala:61)
[info] at org.apache.spark.sql.catalyst.OrderedFilters.$anonfun$predicates$3$adapted(OrderedFilters.scala:50)
[info] at scala.collection.immutable.List.foreach(List.scala:392)
[info] at org.apache.spark.sql.catalyst.OrderedFilters.<init>(OrderedFilters.scala:50)
[info] at org.apache.spark.sql.catalyst.csv.UnivocityParser.<init>(UnivocityParser.scala:103)
[info] at org.apache.spark.sql.execution.datasources.csv.CSVFileFormat.$anonfun$buildReader$1(CSVFileFormat.scala:138)
[info] at org.apache.spark.sql.execution.datasources.FileFormat$$anon$1.apply(FileFormat.scala:148)
[info] at org.apache.spark.sql.execution.datasources.FileFormat$$anon$1.apply(FileFormat.scala:133)
[info] at org.apache.spark.sql.execution.datasources.FileScanRDD$$anon$1.org$apache$spark$sql$execution$datasources$FileScanRDD$$anon$$readCurrentFile(FileScanRDD.scala:117)
[info] at org.apache.spark.sql.execution.datasources.FileScanRDD$$anon$1.nextIterator(FileScanRDD.scala:165)
[info] at org.apache.spark.sql.execution.datasources.FileScanRDD$$anon$1.hasNext(FileScanRDD.scala:94)
[info] at scala.collection.Iterator$$anon$10.hasNext(Iterator.scala:458)
[info] at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage1.processNext(Unknown Source)
[info] at org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
[info] at org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:756)
[info] at org.apache.spark.sql.execution.SparkPlan.$anonfun$getByteArrayRdd$1(SparkPlan.scala:344)
[info] at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2(RDD.scala:898)
[info] at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2$adapted(RDD.scala:898)
[info] at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:52)
[info] at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:373)
[info] at org.apache.spark.rdd.RDD.iterator(RDD.scala:337)
[info] at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
[info] at org.apache.spark.scheduler.Task.run(Task.scala:131)
[info] at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:498)
[info] at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1437)
[info] at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:501)
[info] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[info] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[info] at java.lang.Thread.run(Thread.java:748)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807134827
**[Test build #136533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136533/testReport)** for PR 31964 at commit [`e29aa04`](https://github.com/apache/spark/commit/e29aa0441c193fd3a167a81f845aacb9804a160f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31964:
URL: https://github.com/apache/spark/pull/31964#discussion_r602082043
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala
##########
@@ -148,10 +148,10 @@ package object util extends Logging {
}
def quoteIfNeeded(part: String): String = {
Review comment:
I think it's only for error message or EXPLAIN result (e.g. `Attribute.sql`). @sarutak can you confirm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808354428
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136573/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zsxwing commented on a change in pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
zsxwing commented on a change in pull request #31964:
URL: https://github.com/apache/spark/pull/31964#discussion_r601732216
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala
##########
@@ -148,10 +148,10 @@ package object util extends Logging {
}
def quoteIfNeeded(part: String): String = {
Review comment:
This is a pretty common method. Could you double check if it's okay to change this behavior for other places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-855970208
Ah, of course I mean the case even if we escapes such columns like ```col("`a`b`")```.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808427952
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41157/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31964:
URL: https://github.com/apache/spark/pull/31964#discussion_r603019469
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala
##########
@@ -148,10 +148,10 @@ package object util extends Logging {
}
def quoteIfNeeded(part: String): String = {
Review comment:
I looked into the following classes which use `quoteIfNeeded`
* ResolveSessionCatalog.apply
* IdentifierHelper.quoted
* MultipartIdentifierHelper.quoted
* DatabaseInSessionCatalog$.unapply
* NamespaceHelper.quoted
* Alias.sql
* AttributeReference.sql
* UnresolvedAttribute.sql
* IdentifierImpl.toString
* IdentifierHelper.quoted
Finally, I think this change doesn't break existing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807319949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808071382
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41135/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807240578
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41117/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807050587
**[Test build #136532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136532/testReport)** for PR 31964 at commit [`37bea82`](https://github.com/apache/spark/commit/37bea82ef658154f3973c4ff2452b85f816732e7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-855966983
fixing in https://github.com/apache/spark/pull/32807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807218982
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41116/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-855991505
Ah got it. I've added a test for backtick as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-855966686
@tanelk I think it's a potential bug that filter pushdown cannot handle quoted identifiers.
In fact, if a column contains ``` ` ``` like ```a`b```, the same error happens before this change.
I'll investigate more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808425399
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41157/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mkrasilnikova edited a comment on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
mkrasilnikova edited a comment on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-1011260250
Hello! It seems that there is a bug connected with this pull request.
We use two tables in postgresql with fields named in Russian. And when we are trying to join them with query like
"select view1.\`Имя1\` , view1.\`Имя2\`, view2.\`Имя3\` from view1 left join view2 on view1.\`Имя2\`=view2.\`Имя4\`"
we are getting an error
Caused by: org.postgresql.util.PSQLException: ОШИБКА: столбец "\`Имя4\`" не существует
Hint: Возможно, предполагалась ссылка на столбец "tab2.Имя4".
Position: 49
at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2657)
at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2347)
at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:337)
at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:484)
at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:404)
at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:162)
at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:114)
at org.apache.spark.sql.execution.datasources.jdbc.JDBCRDD.compute(JDBCRDD.scala:362)
It says that there is no field "\`Имя4\`" and offers "tab2.Имя4" instead.
There are no problems with english names.
As far as I can understand to get the data from the second table it constructs query
SELECT "Имя3","Имя4" FROM "public"."tab2" WHERE ("\`Имя4\`" IS NOT NULL) ,
and these redundant backticks in WHERE clause are added in method quoteIfNeeded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808427952
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41157/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807050724
cc: @cloud-fan @zsxwing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-855968461
Oh, @cloud-fan is already fixing. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808000119
**[Test build #136550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136550/testReport)** for PR 31964 at commit [`6faef6b`](https://github.com/apache/spark/commit/6faef6ba70e4ed17f4d26c45566f2c63483b9ad8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807225332
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136533/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-809228495
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808071342
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41135/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31964:
URL: https://github.com/apache/spark/pull/31964#discussion_r601664620
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/StringUtilsSuite.scala
##########
@@ -128,4 +128,13 @@ class StringUtilsSuite extends SparkFunSuite with SQLHelper {
assert(concat.toString === "plan fragment 0plan fragment 1... 15 more characters")
}
}
+ test("SPARK-34872: quoteIfNeeded should quote a string which contains non-word characters") {
Review comment:
nit: a blank line before the new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mkrasilnikova commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
mkrasilnikova commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-1011260250
Hello! It seems that there is a bug connected with this pull request.
We use two tables in postgresql with fields named in Russian. And when we are trying to join them with query like
"select view1.`Имя1` , view1.`Имя2`, view2.`Имя3` from view1 left join view2 on view1.`Имя2`=view2.`Имя4`"
we are getting an error
Caused by: org.postgresql.util.PSQLException: ОШИБКА: столбец "`Имя4`" не существует
Hint: Возможно, предполагалась ссылка на столбец "tab2.Имя4".
Position: 49
at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2657)
at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2347)
at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:337)
at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:484)
at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:404)
at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:162)
at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:114)
at org.apache.spark.sql.execution.datasources.jdbc.JDBCRDD.compute(JDBCRDD.scala:362)
It says that there is no field "`Имя4`" and offers "tab2.Имя4" instead.
There are no problems with english names.
As far as I can understand to get the data from the second table it constructs query
SELECT "Имя3","Имя4" FROM "public"."tab2" WHERE ("`Имя4`" IS NOT NULL) ,
and these redundant quotes in WHERE clause are added in method quoteIfNeeded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mkrasilnikova commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
mkrasilnikova commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-1011979839
Hi @cloud-fan , we started to get this error after we had updated the version from 3.0.2 to 3.2.0. A have just tried with the code from master branch, the bug is still there.
I opened a ticket https://issues.apache.org/jira/browse/SPARK-37895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807223224
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41117/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808354428
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136573/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808100558
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136550/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807319949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808100558
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136550/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mkrasilnikova edited a comment on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
mkrasilnikova edited a comment on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-1011979839
Hi @cloud-fan , we started to get this error after we had updated the version from 3.0.2 to 3.2.0 (and started to use JDBCTableCatalog) A have just tried with the code from master branch, the bug is still there.
I opened a ticket https://issues.apache.org/jira/browse/SPARK-37895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31964:
URL: https://github.com/apache/spark/pull/31964#discussion_r602201864
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala
##########
@@ -148,10 +148,10 @@ package object util extends Logging {
}
def quoteIfNeeded(part: String): String = {
Review comment:
I'm now confirming but, for now, I don't think this change breaks existing behavior except for display format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807305760
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41116/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807134827
**[Test build #136533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136533/testReport)** for PR 31964 at commit [`e29aa04`](https://github.com/apache/spark/commit/e29aa0441c193fd3a167a81f845aacb9804a160f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807050587
**[Test build #136532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136532/testReport)** for PR 31964 at commit [`37bea82`](https://github.com/apache/spark/commit/37bea82ef658154f3973c4ff2452b85f816732e7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-1011748753
Hi @mkrasilnikova , can you open a JIRA ticket to report this bug? The Spark codebase is being updated quite frequently and we at least need to know which Spark version has this bug. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808315516
retest this please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808392866
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41157/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807221419
**[Test build #136533 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136533/testReport)** for PR 31964 at commit [`e29aa04`](https://github.com/apache/spark/commit/e29aa0441c193fd3a167a81f845aacb9804a160f).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807240578
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41117/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807240514
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41117/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-855969103
@sarutak backtick doesn't work because `col(...)` runs a small parser to parse the name, and backtick has a meaning there and you need to escape it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808065050
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41135/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808316466
**[Test build #136573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136573/testReport)** for PR 31964 at commit [`6faef6b`](https://github.com/apache/spark/commit/6faef6ba70e4ed17f4d26c45566f2c63483b9ad8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807316699
**[Test build #136532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136532/testReport)** for PR 31964 at commit [`37bea82`](https://github.com/apache/spark/commit/37bea82ef658154f3973c4ff2452b85f816732e7).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-807225332
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136533/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31964: [SPARK-34872][SQL] quoteIfNeeded should quote a name which contains non-word characters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31964:
URL: https://github.com/apache/spark/pull/31964#issuecomment-808071382
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41135/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org