You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexander Simbirtsev (JIRA)" <ji...@apache.org> on 2006/12/13 13:15:21 UTC
[jira] Created: (HARMONY-2666) [classlib][swing]
javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw
unspecified NPE while RI does
[classlib][swing] javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw unspecified NPE while RI does
----------------------------------------------------------------------------------------------------------------------
Key: HARMONY-2666
URL: http://issues.apache.org/jira/browse/HARMONY-2666
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Alexander Simbirtsev
Priority: Minor
There is no mention of any exception in the specification.
Harmony does not throw unspecified NPE for MetalInternalFrameTitlePane(null)
while RI does.
Use the following code to reproduce:
import javax.swing.JInternalFrame;
import javax.swing.plaf.basic.BasicInternalFrameTitlePane;
import junit.framework.TestCase;
public class Test extends TestCase {
public static void main(String[] args) {
try {
new BasicInternalFrameTitlePane((JInternalFrame) null);
} catch (Exception e) {
e.printStackTrace();
}
}
}
Inconsistency is that in Harmony's implementation of this constructor
installTitlePane() is not called when null parameter is passed in
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2666) [classlib][swing]
javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw
unspecified NPE while RI does
Posted by "Alexander Simbirtsev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474097 ]
Alexander Simbirtsev commented on HARMONY-2666:
-----------------------------------------------
Agree with a comment above.
New issue should be open to address the problems disclosed in MetalRootPaneTitlePane's implementation.
> [classlib][swing] javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw unspecified NPE while RI does
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2666
> URL: https://issues.apache.org/jira/browse/HARMONY-2666
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexander Simbirtsev
> Assigned To: Mark Hindess
> Priority: Minor
> Attachments: Harmony-2666-BasicInternalFrameTitlePane.patch, Harmony-2666-BasicInternalFrameTitlePaneTest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony does not throw unspecified NPE for MetalInternalFrameTitlePane(null)
> while RI does.
> Use the following code to reproduce:
> import javax.swing.JInternalFrame;
> import javax.swing.plaf.basic.BasicInternalFrameTitlePane;
> import junit.framework.TestCase;
> public class Test extends TestCase {
> public static void main(String[] args) {
> try {
> new BasicInternalFrameTitlePane((JInternalFrame) null);
> } catch (Exception e) {
> e.printStackTrace();
> }
> }
> }
> Inconsistency is that in Harmony's implementation of this constructor
> installTitlePane() is not called when null parameter is passed in
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-2666) [classlib][swing]
javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw
unspecified NPE while RI does
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474104 ]
Alexey A. Ivanov commented on HARMONY-2666:
-------------------------------------------
Sergey, Alexey,
Of course, this is the problem! But not throwing NPE courses much less harm than throwing NPE when an application want to use L&F decorations. Does it make sense?
To avoid NPE with L&F decoration the code should be re-designed -- it's not a easy thing.
Harmony implementation shares implementation of BasicInternalFrame (which is child frames) on the main frame. Obviously it's good to share the code. But BasicInternalFrame can't configure itself correctly if null is passed to its constructor -- this is the case where main frame (i.e. of JFrame) decorations are initialized.
> [classlib][swing] javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw unspecified NPE while RI does
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2666
> URL: https://issues.apache.org/jira/browse/HARMONY-2666
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexander Simbirtsev
> Assigned To: Mark Hindess
> Priority: Minor
> Attachments: Harmony-2666-BasicInternalFrameTitlePane.patch, Harmony-2666-BasicInternalFrameTitlePaneTest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony does not throw unspecified NPE for MetalInternalFrameTitlePane(null)
> while RI does.
> Use the following code to reproduce:
> import javax.swing.JInternalFrame;
> import javax.swing.plaf.basic.BasicInternalFrameTitlePane;
> import junit.framework.TestCase;
> public class Test extends TestCase {
> public static void main(String[] args) {
> try {
> new BasicInternalFrameTitlePane((JInternalFrame) null);
> } catch (Exception e) {
> e.printStackTrace();
> }
> }
> }
> Inconsistency is that in Harmony's implementation of this constructor
> installTitlePane() is not called when null parameter is passed in
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-2666) [classlib][swing]
javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw
unspecified NPE while RI does
Posted by "Sergey Krivenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473698 ]
Sergey Krivenko commented on HARMONY-2666:
------------------------------------------
I disagree with the previous comment. Despite throwing NPE for MetalInternalFrameTitlePane(null) on RI it works just fine with L&F decorated windows. So there must be a problem there.
> [classlib][swing] javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw unspecified NPE while RI does
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2666
> URL: https://issues.apache.org/jira/browse/HARMONY-2666
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexander Simbirtsev
> Assigned To: Mark Hindess
> Priority: Minor
> Attachments: Harmony-2666-BasicInternalFrameTitlePane.patch, Harmony-2666-BasicInternalFrameTitlePaneTest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony does not throw unspecified NPE for MetalInternalFrameTitlePane(null)
> while RI does.
> Use the following code to reproduce:
> import javax.swing.JInternalFrame;
> import javax.swing.plaf.basic.BasicInternalFrameTitlePane;
> import junit.framework.TestCase;
> public class Test extends TestCase {
> public static void main(String[] args) {
> try {
> new BasicInternalFrameTitlePane((JInternalFrame) null);
> } catch (Exception e) {
> e.printStackTrace();
> }
> }
> }
> Inconsistency is that in Harmony's implementation of this constructor
> installTitlePane() is not called when null parameter is passed in
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-2666) [classlib][swing]
javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw
unspecified NPE while RI does
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess resolved HARMONY-2666.
-----------------------------------
Resolution: Fixed
Assignee: Mark Hindess
Applied patches in r496043. Please confirm they have been applied as expected.
> [classlib][swing] javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw unspecified NPE while RI does
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2666
> URL: https://issues.apache.org/jira/browse/HARMONY-2666
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexander Simbirtsev
> Assigned To: Mark Hindess
> Priority: Minor
> Attachments: Harmony-2666-BasicInternalFrameTitlePane.patch, Harmony-2666-BasicInternalFrameTitlePaneTest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony does not throw unspecified NPE for MetalInternalFrameTitlePane(null)
> while RI does.
> Use the following code to reproduce:
> import javax.swing.JInternalFrame;
> import javax.swing.plaf.basic.BasicInternalFrameTitlePane;
> import junit.framework.TestCase;
> public class Test extends TestCase {
> public static void main(String[] args) {
> try {
> new BasicInternalFrameTitlePane((JInternalFrame) null);
> } catch (Exception e) {
> e.printStackTrace();
> }
> }
> }
> Inconsistency is that in Harmony's implementation of this constructor
> installTitlePane() is not called when null parameter is passed in
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2666) [classlib][swing]
javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw
unspecified NPE while RI does
Posted by "Alexander Simbirtsev (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2666?page=all ]
Alexander Simbirtsev updated HARMONY-2666:
------------------------------------------
Patch Info: [Patch Available]
> [classlib][swing] javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw unspecified NPE while RI does
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2666
> URL: http://issues.apache.org/jira/browse/HARMONY-2666
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexander Simbirtsev
> Priority: Minor
> Attachments: Harmony-2666-BasicInternalFrameTitlePane.patch, Harmony-2666-BasicInternalFrameTitlePaneTest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony does not throw unspecified NPE for MetalInternalFrameTitlePane(null)
> while RI does.
> Use the following code to reproduce:
> import javax.swing.JInternalFrame;
> import javax.swing.plaf.basic.BasicInternalFrameTitlePane;
> import junit.framework.TestCase;
> public class Test extends TestCase {
> public static void main(String[] args) {
> try {
> new BasicInternalFrameTitlePane((JInternalFrame) null);
> } catch (Exception e) {
> e.printStackTrace();
> }
> }
> }
> Inconsistency is that in Harmony's implementation of this constructor
> installTitlePane() is not called when null parameter is passed in
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2666) [classlib][swing]
javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw
unspecified NPE while RI does
Posted by "Sergey Krivenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2666?page=all ]
Sergey Krivenko updated HARMONY-2666:
-------------------------------------
Attachment: Harmony-2666-BasicInternalFrameTitlePaneTest.patch
the attached is a patch to the test
> [classlib][swing] javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw unspecified NPE while RI does
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2666
> URL: http://issues.apache.org/jira/browse/HARMONY-2666
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexander Simbirtsev
> Priority: Minor
> Attachments: Harmony-2666-BasicInternalFrameTitlePane.patch, Harmony-2666-BasicInternalFrameTitlePaneTest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony does not throw unspecified NPE for MetalInternalFrameTitlePane(null)
> while RI does.
> Use the following code to reproduce:
> import javax.swing.JInternalFrame;
> import javax.swing.plaf.basic.BasicInternalFrameTitlePane;
> import junit.framework.TestCase;
> public class Test extends TestCase {
> public static void main(String[] args) {
> try {
> new BasicInternalFrameTitlePane((JInternalFrame) null);
> } catch (Exception e) {
> e.printStackTrace();
> }
> }
> }
> Inconsistency is that in Harmony's implementation of this constructor
> installTitlePane() is not called when null parameter is passed in
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-2666) [classlib][swing]
javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw
unspecified NPE while RI does
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess closed HARMONY-2666.
---------------------------------
Verified. Thanks.
> [classlib][swing] javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw unspecified NPE while RI does
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2666
> URL: https://issues.apache.org/jira/browse/HARMONY-2666
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexander Simbirtsev
> Assigned To: Mark Hindess
> Priority: Minor
> Attachments: Harmony-2666-BasicInternalFrameTitlePane.patch, Harmony-2666-BasicInternalFrameTitlePaneTest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony does not throw unspecified NPE for MetalInternalFrameTitlePane(null)
> while RI does.
> Use the following code to reproduce:
> import javax.swing.JInternalFrame;
> import javax.swing.plaf.basic.BasicInternalFrameTitlePane;
> import junit.framework.TestCase;
> public class Test extends TestCase {
> public static void main(String[] args) {
> try {
> new BasicInternalFrameTitlePane((JInternalFrame) null);
> } catch (Exception e) {
> e.printStackTrace();
> }
> }
> }
> Inconsistency is that in Harmony's implementation of this constructor
> installTitlePane() is not called when null parameter is passed in
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2666) [classlib][swing]
javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw
unspecified NPE while RI does
Posted by "Sergey Krivenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464926 ]
Sergey Krivenko commented on HARMONY-2666:
------------------------------------------
Verified
> [classlib][swing] javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw unspecified NPE while RI does
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2666
> URL: https://issues.apache.org/jira/browse/HARMONY-2666
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexander Simbirtsev
> Assigned To: Mark Hindess
> Priority: Minor
> Attachments: Harmony-2666-BasicInternalFrameTitlePane.patch, Harmony-2666-BasicInternalFrameTitlePaneTest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony does not throw unspecified NPE for MetalInternalFrameTitlePane(null)
> while RI does.
> Use the following code to reproduce:
> import javax.swing.JInternalFrame;
> import javax.swing.plaf.basic.BasicInternalFrameTitlePane;
> import junit.framework.TestCase;
> public class Test extends TestCase {
> public static void main(String[] args) {
> try {
> new BasicInternalFrameTitlePane((JInternalFrame) null);
> } catch (Exception e) {
> e.printStackTrace();
> }
> }
> }
> Inconsistency is that in Harmony's implementation of this constructor
> installTitlePane() is not called when null parameter is passed in
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2666) [classlib][swing]
javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw
unspecified NPE while RI does
Posted by "Sergey Krivenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2666?page=all ]
Sergey Krivenko updated HARMONY-2666:
-------------------------------------
Attachment: Harmony-2666-BasicInternalFrameTitlePane.patch
the attached is a fix to the bug
> [classlib][swing] javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw unspecified NPE while RI does
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2666
> URL: http://issues.apache.org/jira/browse/HARMONY-2666
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexander Simbirtsev
> Priority: Minor
> Attachments: Harmony-2666-BasicInternalFrameTitlePane.patch
>
>
> There is no mention of any exception in the specification.
> Harmony does not throw unspecified NPE for MetalInternalFrameTitlePane(null)
> while RI does.
> Use the following code to reproduce:
> import javax.swing.JInternalFrame;
> import javax.swing.plaf.basic.BasicInternalFrameTitlePane;
> import junit.framework.TestCase;
> public class Test extends TestCase {
> public static void main(String[] args) {
> try {
> new BasicInternalFrameTitlePane((JInternalFrame) null);
> } catch (Exception e) {
> e.printStackTrace();
> }
> }
> }
> Inconsistency is that in Harmony's implementation of this constructor
> installTitlePane() is not called when null parameter is passed in
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2666) [classlib][swing]
javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw
unspecified NPE while RI does
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473684 ]
Alexey A. Ivanov commented on HARMONY-2666:
-------------------------------------------
I guess the patch is not correct: Applying this patch prevents Swing applications from using L&F decorated windows. I think this problem is much more serious than NPE-compatibility in this case.
There should be provided another fix to this minor exception compatibility. I suggest to revert the patch.
> [classlib][swing] javax.swing.plaf.metal.BasicInternalFrameTitlePane(null) doesn't throw unspecified NPE while RI does
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2666
> URL: https://issues.apache.org/jira/browse/HARMONY-2666
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexander Simbirtsev
> Assigned To: Mark Hindess
> Priority: Minor
> Attachments: Harmony-2666-BasicInternalFrameTitlePane.patch, Harmony-2666-BasicInternalFrameTitlePaneTest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony does not throw unspecified NPE for MetalInternalFrameTitlePane(null)
> while RI does.
> Use the following code to reproduce:
> import javax.swing.JInternalFrame;
> import javax.swing.plaf.basic.BasicInternalFrameTitlePane;
> import junit.framework.TestCase;
> public class Test extends TestCase {
> public static void main(String[] args) {
> try {
> new BasicInternalFrameTitlePane((JInternalFrame) null);
> } catch (Exception e) {
> e.printStackTrace();
> }
> }
> }
> Inconsistency is that in Harmony's implementation of this constructor
> installTitlePane() is not called when null parameter is passed in
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.