You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/08 00:50:38 UTC
[GitHub] [airflow] potiuk opened a new pull request #13556: The check for image is now more robust
potiuk opened a new pull request #13556:
URL: https://github.com/apache/airflow/pull/13556
Seems that for GitHub Actions, the response to check status
of the image might sometimes return slightly different output.
In order to check for presence of the image we now check for
presence of the quoted tag.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13556: The check for image is now more robust
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13556:
URL: https://github.com/apache/airflow/pull/13556#issuecomment-756483053
Luckily in both cases same error:
`{"errors":[{"code":"MANIFEST_UNKNOWN","message":"Docker image reference master-python3.6-ci:470415985 not found under repo \"apache\""}]}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13556: The check for image is now more robust
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13556:
URL: https://github.com/apache/airflow/pull/13556#issuecomment-756492947
Looks red but it's quarantined test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13556: The check for image is now more robust
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13556:
URL: https://github.com/apache/airflow/pull/13556#issuecomment-756587066
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13556: The check for image is now more robust
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13556:
URL: https://github.com/apache/airflow/pull/13556
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13556: The check for image is now more robust
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13556:
URL: https://github.com/apache/airflow/pull/13556#issuecomment-756482665
:facepalm: :facepalm:
It turns out that sometime we get schema 2 answer:
https://github.com/apache/airflow/pull/13556/checks?check_run_id=1666011321#step:5:403
```
{
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"config": {
"mediaType": "application/vnd.docker.container.image.v1+json",
"size": 56952,
"digest": "sha256:5c80e2ab289647802affafc5c1efc879fe4f5b559cb7a2a1215868e84b1d6424"
},
```
And sometimes schema 1 answer:
https://github.com/apache/airflow/runs/1665801504?check_suite_focus=true#step:5:240
```
{
"schemaVersion": 1,
"name": "apache/airflow/master-python3.6-ci",
"tag": "470317521",
"architecture": "amd64",
"fsLayers": [
{
```
:facepalm: :facepalm: :facepalm: :facepalm: :facepalm: :facepalm: :facepalm: :facepalm: :facepalm:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13556: The check for image is now more robust
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13556:
URL: https://github.com/apache/airflow/pull/13556#issuecomment-756477496
Looks like the response of the API call to check if image is available (retrieving manifest) sometimes returns digest of the image and sometimes it does not :(
Example here: https://github.com/apache/airflow/pull/13409/checks?check_run_id=1665801504#step:5:239
Checking for quoted image tag should help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org