[GitHub] [spark] hvanhovell commented on a diff in pull request #41883: [SPARK-44322][CONNECT] Make parser use SqlApiConf instead of SQLConf.

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #41883:
URL: https://github.com/apache/spark/pull/41883#discussion_r1255376027


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/parsers.scala:
##########
@@ -99,6 +98,8 @@ abstract class AbstractParser extends DataTypeParserInterface with SQLConfHelper
           e.errorClass, e.messageParameters)
     }
   }
+
+  private def conf: SqlApiConf = SqlApiConf.get

Review Comment:
   I am not going to add a trait if there is only one place where we are using it. For the record the original trait was added to make it easier to migrate existing code to the `SQLConf.get` based world. I don't really think adding it adds much value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org