You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2022/12/02 17:25:37 UTC

[GitHub] [knox] zeroflag commented on a diff in pull request #688: KNOX-2850 - Bumped shiro, jetty, postgresql, hadoop, woodstox dependencies

zeroflag commented on code in PR #688:
URL: https://github.com/apache/knox/pull/688#discussion_r1038363283


##########
pom.xml:
##########
@@ -1565,6 +1565,10 @@
                         <groupId>org.slf4j</groupId>
                         <artifactId>slf4j-log4j12</artifactId>
                     </exclusion>
+                    <exclusion>

Review Comment:
   The `slf4j-reload4j` is the same as `slf4j-log4j12` but for reload4j (which is a up to date version of log4j one). Given that hadoop or other components might use slf4j for logging instead log4j (what knox uses) we need some kind of bridging library between those two. But this is for log4j1. So slf4j knows about how to log using Log4j/reload4j. But knox uses log4j2. So I don't think this is needed. I think the exclusion is fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org