You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "William Bardwell (JIRA)" <ji...@apache.org> on 2010/09/24 16:01:34 UTC

[jira] Created: (TS-458) INKCacheKeyHostNameSet and INKCacheKeyDigestSet take unsigned char * and nothing else does

INKCacheKeyHostNameSet and INKCacheKeyDigestSet take unsigned char * and nothing else does
------------------------------------------------------------------------------------------

                 Key: TS-458
                 URL: https://issues.apache.org/jira/browse/TS-458
             Project: Traffic Server
          Issue Type: Bug
          Components: InkAPI
    Affects Versions: 2.1.0
         Environment: Any
            Reporter: William Bardwell


INKCacheKeyHostNameSet and INKCacheKeyDigestSet take unsigned char * arguments and nothing else does, and in their implementations they have to cast that away.  So next time the APIs are safe to be revised they should be fixed to match everything else.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-458) INKCacheKeyHostNameSet and INKCacheKeyDigestSet take unsigned char * and nothing else does

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom updated TS-458:
-----------------------------

    Fix Version/s:     (was: 2.99)
                   2.1.5

> INKCacheKeyHostNameSet and INKCacheKeyDigestSet take unsigned char * and nothing else does
> ------------------------------------------------------------------------------------------
>
>                 Key: TS-458
>                 URL: https://issues.apache.org/jira/browse/TS-458
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: InkAPI
>    Affects Versions: 2.1.0
>         Environment: Any
>            Reporter: William Bardwell
>             Fix For: 2.1.5
>
>
> INKCacheKeyHostNameSet and INKCacheKeyDigestSet take unsigned char * arguments and nothing else does, and in their implementations they have to cast that away.  So next time the APIs are safe to be revised they should be fixed to match everything else.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-458) INKCacheKeyHostNameSet and INKCacheKeyDigestSet take unsigned char * and nothing else does

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom updated TS-458:
-----------------------------

    Fix Version/s: 2.99

We should look into fixing this for the last developer release before the v3.0 release. We have a contract not to break APIs / ABIs within a major release version (.e. 2.x). But indeed, CacheInfo declares the hostname as "char*", i.e.

struct CacheInfo
{
  INK_MD5 cache_key;
  CacheFragType frag_type;
  char *hostname;

Thanks!

-- leif


> INKCacheKeyHostNameSet and INKCacheKeyDigestSet take unsigned char * and nothing else does
> ------------------------------------------------------------------------------------------
>
>                 Key: TS-458
>                 URL: https://issues.apache.org/jira/browse/TS-458
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: InkAPI
>    Affects Versions: 2.1.0
>         Environment: Any
>            Reporter: William Bardwell
>             Fix For: 2.99
>
>
> INKCacheKeyHostNameSet and INKCacheKeyDigestSet take unsigned char * arguments and nothing else does, and in their implementations they have to cast that away.  So next time the APIs are safe to be revised they should be fixed to match everything else.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.