You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "BryanMLima (via GitHub)" <gi...@apache.org> on 2024/02/29 19:53:48 UTC
[I] [UI] Storage menu not showing even with API permissions [cloudstack]
BryanMLima opened a new issue, #8730:
URL: https://github.com/apache/cloudstack/issues/8730
##### ISSUE TYPE
* Bug Report
##### COMPONENT NAME
~~~
UI
~~~
##### CLOUDSTACK VERSION
~~~
Main
~~~
##### SUMMARY
As reported in https://github.com/apache/cloudstack/pull/8713#issuecomment-1969866705, the `Storage` submenu in the sidebar is not displayed to users when they do not have permission to the API `listVolumesMetrics`. However, roles can have permissions to other APIs, such as `listBackups` and `listSnapshots`, in which case the submenu should be displayed. This scenario is probably not exclusive to the `Storage` menu.
##### STEPS TO REPRODUCE
Create a role with permission to allow the APIs `listBackups` and `listSnapshots` and deny the API `listVolumesMetrics`. The UI dashboard will not show the `Storage` menu in the sidebar.
##### EXPECTED RESULTS
The UI should show the `Storage` submenu alongside with its own `Backups` and `Snapshots` submenus.
##### ACTUAL RESULTS
The submenu `Storage` is not displayed, even though the role has permission to list snapshots and backups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [UI] Storage menu not showing even with API permissions [cloudstack]
Posted by "BryanMLima (via GitHub)" <gi...@apache.org>.
BryanMLima commented on issue #8730:
URL: https://github.com/apache/cloudstack/issues/8730#issuecomment-1971863831
@DaanHoogland @winterhazel @sureshanaparti, I am probably overthinking this scenario, however, the `permission` property in the JS component (`storage.js`) works like an AND operator. Maybe it could function like an OR operator as well; what do you guys think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [UI] Storage menu not showing even with API permissions [cloudstack]
Posted by "BryanMLima (via GitHub)" <gi...@apache.org>.
BryanMLima commented on issue #8730:
URL: https://github.com/apache/cloudstack/issues/8730#issuecomment-2085855924
Closing this as this was addressed in PR #8978.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [UI] Storage menu not showing even with API permissions [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #8730:
URL: https://github.com/apache/cloudstack/issues/8730#issuecomment-1976223664
> @DaanHoogland @winterhazel @sureshanaparti, I am probably overthinking this scenario, however, the `permission` property in the JS component (`storage.js`) works like an AND operator. Maybe it could function like an OR operator as well; what do you guys think?
This was exactly my thought when I learned of it @BryanMLima . Let's try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [UI] Storage menu not showing even with API permissions [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed issue #8730: [UI] Storage menu not showing even with API permissions
URL: https://github.com/apache/cloudstack/issues/8730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [UI] Storage menu not showing even with API permissions [cloudstack]
Posted by "winterhazel (via GitHub)" <gi...@apache.org>.
winterhazel commented on issue #8730:
URL: https://github.com/apache/cloudstack/issues/8730#issuecomment-2077261084
Hey everyone,
I've implemented @BryanMLima's idea in #8978. The filtering still works as an AND operator for routes that correspond to a page; however, I have changed so that routes corresponding to sections get shown if the user has access to any of its pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org