You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2020/12/07 16:03:21 UTC

[native-toolchain-CR] IMPALA-9985/IMPALA-10011: Update supported platforms, fix Maven download

Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16823


Change subject: IMPALA-9985/IMPALA-10011: Update supported platforms, fix Maven download
......................................................................

IMPALA-9985/IMPALA-10011: Update supported platforms, fix Maven download

Based on recent operating system releases and retirements the list of
platforms supported by the binary toolchain build is updated as follows:

Add Centos 8.
CentOS 8 support  starts with version 8.2, which is the most recent minor
release for this platform. Earlier releases were impacted by several
glibc problems, which impacted the GCC binaries in the toolchain (both
4.9.2 and 7.5), causing compilation failures when building Impala.
A few of these problems are listed in [1], all of which are fixed in
CentOS 8.2 by including an updated version of glibc.

Remove Debian 8.
Debian 8 has reached end-of-support on June 30th, 2020; see the
announcement at [2]. The repo signature verification problems described
in IMPALA-10011 were a corollary to this retirement, as infrastructure
fell into disuse.
This patch removes Debian 8 from the list of Docker containers built
for toolchain builds, it also removes Debian 8 from the toolchain target
list.

Additionally change the Maven download URL to point to the new Apache
official archive site for a stable and maintained repo location.

[1] https://issues.apache.org/jira/browse/IMPALA-9985#comment-17163097
[2] https://www.debian.org/News/2020/20200709

Change-Id: Ib622f1e636e8b17b72c67b3d48964acea20db9ff
---
M Makefile
M docker/all/postinstall.sh
D docker/debian/8/99no-check-valid-until
D docker/debian/8/sources.list
D docker/debian8.df
M docker/redhat8.df
M in-docker.py
7 files changed, 5 insertions(+), 59 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/23/16823/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib622f1e636e8b17b72c67b3d48964acea20db9ff
Gerrit-Change-Number: 16823
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>

[native-toolchain-CR] IMPALA-9985/IMPALA-10011: Update supported platforms, fix Maven download

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.

Laszlo Gaal has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16823 )

Change subject: IMPALA-9985/IMPALA-10011: Update supported platforms, fix Maven download
......................................................................

IMPALA-9985/IMPALA-10011: Update supported platforms, fix Maven download

Based on recent operating system releases and retirements the list of
platforms supported by the binary toolchain build is updated as follows:

Add Centos 8.
CentOS 8 support starts with version 8.2, which is the most recent minor
release for this platform. Earlier releases were impacted by several
glibc problems, which impacted the GCC binaries in the toolchain (both
4.9.2 and 7.5), causing compilation failures when building Impala.
A few of these problems are listed in [1], all of which are fixed in
CentOS 8.2 by including an updated version of glibc.

Remove Debian 8.
Debian 8 has reached end-of-support on June 30th, 2020; see the
announcement at [2]. The repo signature verification problems described
in IMPALA-10011 were a corollary to this retirement, as infrastructure
fell into disuse.
This patch removes Debian 8 from the list of Docker containers built
for toolchain builds, it also removes Debian 8 from the toolchain target
list.

Additionally change the Maven download URL to point to the new Apache
official archive site for a stable and maintained repo location.

[1] https://issues.apache.org/jira/browse/IMPALA-9985#comment-17163097
[2] https://www.debian.org/News/2020/20200709

Tests:
1. Built all the containers for toolchain builds
2. Built and published a new build of the toolchain for the new list of
platforms, using the containers prepared in step 1.
3. Ran Impala core-mode tests on Centos 7 and Centos 8. Impala compiled
successfully, so this fixes IMPALA-9985. Tests passed on Centos 7.
Centos 8 showed a single cipherset-related failure in
thrift-server-test on Centos 8, for which an upstream Jira will be
filed.

All these steps (except the thrift-server-test failure in step 3) were
successful; they were executed on private infrastructure.

Change-Id: Ib622f1e636e8b17b72c67b3d48964acea20db9ff
Reviewed-on: http://gerrit.cloudera.org:8080/16823
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Laszlo Gaal <la...@cloudera.com>
---
M Makefile
M docker/all/postinstall.sh
D docker/debian/8/99no-check-valid-until
D docker/debian/8/sources.list
D docker/debian8.df
M docker/redhat8.df
M in-docker.py
7 files changed, 5 insertions(+), 59 deletions(-)

Approvals:
Tim Armstrong: Looks good to me, approved
Laszlo Gaal: Verified

--
To view, visit http://gerrit.cloudera.org:8080/16823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib622f1e636e8b17b72c67b3d48964acea20db9ff
Gerrit-Change-Number: 16823
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>