You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/05 01:08:21 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4679: [#4667] Fix
auto-tuning algorithm to update when parameters are changed
codecov-io commented on issue #4679: [#4667] Fix auto-tuning algorithm to update when parameters are changed
URL: https://github.com/apache/incubator-pinot/pull/4679#issuecomment-538603131
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4679?src=pr&el=h1) Report
> Merging [#4679](https://codecov.io/gh/apache/incubator-pinot/pull/4679?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/492d7808d19c9e12347cdd222dc63dbdb105b2c3?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `91.42%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4679?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4679 +/- ##
============================================
- Coverage 64.54% 64.53% -0.01%
Complexity 16 16
============================================
Files 1056 1056
Lines 56192 56197 +5
Branches 8331 8332 +1
============================================
+ Hits 36268 36269 +1
- Misses 17236 17237 +1
- Partials 2688 2691 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4679?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...realtime/segment/DefaultFlushThresholdUpdater.java](https://codecov.io/gh/apache/incubator-pinot/pull/4679/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL3NlZ21lbnQvRGVmYXVsdEZsdXNoVGhyZXNob2xkVXBkYXRlci5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../core/realtime/PinotLLCRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4679/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90TExDUmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh) | `70.61% <100%> (+0.09%)` | `0 <0> (ø)` | :arrow_down: |
| [.../realtime/segment/FlushThresholdUpdateManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4679/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL3NlZ21lbnQvRmx1c2hUaHJlc2hvbGRVcGRhdGVNYW5hZ2VyLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...segment/SegmentSizeBasedFlushThresholdUpdater.java](https://codecov.io/gh/apache/incubator-pinot/pull/4679/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL3NlZ21lbnQvU2VnbWVudFNpemVCYXNlZEZsdXNoVGhyZXNob2xkVXBkYXRlci5qYXZh) | `73.23% <88.88%> (+2.47%)` | `0 <0> (ø)` | :arrow_down: |
| [...he/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4679/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvVmFsaWRTZWdtZW50UHJ1bmVyLmphdmE=) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | |
| [.../apache/pinot/core/transport/DataTableHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4679/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvRGF0YVRhYmxlSGFuZGxlci5qYXZh) | `88% <0%> (-12%)` | `0% <0%> (ø)` | |
| [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4679/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlbG9jYXRpb24vUmVhbHRpbWVTZWdtZW50UmVsb2NhdG9yLmphdmE=) | `30% <0%> (-10%)` | `0% <0%> (ø)` | |
| [.../apache/pinot/common/config/RealtimeTagConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4679/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1JlYWx0aW1lVGFnQ29uZmlnLmphdmE=) | `93.33% <0%> (-6.67%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4679/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `66.66% <0%> (-6.46%)` | `0% <0%> (ø)` | |
| [...org/apache/pinot/client/DynamicBrokerSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/4679/diff?src=pr&el=tree#diff-cGlub3QtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jbGllbnQvRHluYW1pY0Jyb2tlclNlbGVjdG9yLmphdmE=) | `69.69% <0%> (-3.04%)` | `0% <0%> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/incubator-pinot/pull/4679/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4679?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4679?src=pr&el=footer). Last update [492d780...a7bfca7](https://codecov.io/gh/apache/incubator-pinot/pull/4679?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org