You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2022/05/10 14:34:17 UTC
[GitHub] [carbondata] maheshrajus opened a new pull request, #4264: [CARBONDATA-4335] Disable by default
maheshrajus opened a new pull request, #4264:
URL: https://github.com/apache/carbondata/pull/4264
### Why is this PR needed?
Currently materialized view(mv) is enabled by default. In concurrent scenarios with default mv enabled each session is going through the list of databases even though mv not used. Due to this query time increased.
### What changes were proposed in this PR?
Disable mv by default as users using mv rarely. If user required then enable and use it.
### Does this PR introduce any user interface change?
- No
### Is any new testcase added?
- Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1143139653
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a diff in pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on code in PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#discussion_r884464939
##########
integration/spark/src/test/scala/org/apache/carbondata/view/rewrite/MVFilterAndJoinTest.scala:
##########
@@ -29,9 +29,11 @@ class MVFilterAndJoinTest extends QueryTest with BeforeAndAfterAll {
sql("create table main_table (name string,age int,height int) STORED AS carbondata")
sql("create table dim_table (name string,age int,height int) STORED AS carbondata")
sql("create table sdr_table (name varchar(20),score int) STORED AS carbondata")
+ sql("set carbon.enable.mv = true")
}
def drop() {
+ sql("set carbon.enable.mv = false")
Review Comment:
please move this to afterALL method. please check and handle in other changed files as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1143139569
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1143454947
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4589/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on a diff in pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on code in PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#discussion_r885477800
##########
integration/spark/src/test/scala/org/apache/carbondata/view/rewrite/MVFilterAndJoinTest.scala:
##########
@@ -29,9 +29,11 @@ class MVFilterAndJoinTest extends QueryTest with BeforeAndAfterAll {
sql("create table main_table (name string,age int,height int) STORED AS carbondata")
sql("create table dim_table (name string,age int,height int) STORED AS carbondata")
sql("create table sdr_table (name varchar(20),score int) STORED AS carbondata")
+ sql("set carbon.enable.mv = true")
}
def drop() {
+ sql("set carbon.enable.mv = false")
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1124002746
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4555/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] brijoobopanna commented on a diff in pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
brijoobopanna commented on code in PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#discussion_r870942827
##########
docs/configuration-parameters.md:
##########
@@ -142,7 +142,7 @@ This section provides the details of all the configurations required for the Car
| carbon.scheduler.min.registered.resources.ratio | 0.8 | Specifies the minimum resource (executor) ratio needed for starting the block distribution. The default value is 0.8, which indicates 80% of the requested resource is allocated for starting block distribution. The minimum value is 0.1 min and the maximum value is 1.0. |
| carbon.detail.batch.size | 100 | The buffer size to store records, returned from the block scan. In limit scenario this parameter is very important. For example your query limit is 1000. But if we set this value to 3000 that means we get 3000 records from scan but spark will only take 1000 rows. So the 2000 remaining are useless. In one Finance test case after we set it to 100, in the limit 1000 scenario the performance increase about 2 times in comparison to if we set this value to 12000.<br /><br /> **NOTE** The minimum batch size allowed is 100 and maximum batch size allowed by this property is 1000. |
| carbon.enable.vector.reader | true | Spark added vector processing to optimize cpu cache miss and there by increase the query performance. This configuration enables to fetch data as columnar batch of size 4*1024 rows instead of fetching data row by row and provide it to spark so that there is improvement in select queries performance. |
-| carbon.enable.mv | true | Whether to rewrite the query plan based on the materialized views, Default value is true |
Review Comment:
if any open source community user has been using MV this will impact thier upgrade, hope the upgrade document is clear and upgrade steps are ensured
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a diff in pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on code in PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#discussion_r873388120
##########
integration/flink/src/test/scala/org/apache/carbon/flink/TestCarbonPartitionWriter.scala:
##########
@@ -335,7 +335,7 @@ class TestCarbonPartitionWriter extends QueryTest with BeforeAndAfterAll {
}
assert(tables.exists(_.identifier.table.equalsIgnoreCase("mv_1")))
checkAnswer(df, Seq(Row("test9", 12345)))
-
+ sql("set carbon.enable.mv = false")
Review Comment:
better to move this under finally block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1136113524
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/6325/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1123999840
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/6300/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1123475210
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/6299/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1136925290
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/6328/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1143446954
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/6334/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1122846818
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/6298/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1136143032
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/713/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1142260903
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/6333/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4264: [CARBONDATA-4335] Disable MV by default
URL: https://github.com/apache/carbondata/pull/4264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1122855493
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4553/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1122879979
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/688/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1123671839
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1136914203
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4583/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1141963458
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on a diff in pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on code in PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#discussion_r885283693
##########
docs/configuration-parameters.md:
##########
@@ -142,7 +142,7 @@ This section provides the details of all the configurations required for the Car
| carbon.scheduler.min.registered.resources.ratio | 0.8 | Specifies the minimum resource (executor) ratio needed for starting the block distribution. The default value is 0.8, which indicates 80% of the requested resource is allocated for starting block distribution. The minimum value is 0.1 min and the maximum value is 1.0. |
| carbon.detail.batch.size | 100 | The buffer size to store records, returned from the block scan. In limit scenario this parameter is very important. For example your query limit is 1000. But if we set this value to 3000 that means we get 3000 records from scan but spark will only take 1000 rows. So the 2000 remaining are useless. In one Finance test case after we set it to 100, in the limit 1000 scenario the performance increase about 2 times in comparison to if we set this value to 12000.<br /><br /> **NOTE** The minimum batch size allowed is 100 and maximum batch size allowed by this property is 1000. |
| carbon.enable.vector.reader | true | Spark added vector processing to optimize cpu cache miss and there by increase the query performance. This configuration enables to fetch data as columnar batch of size 4*1024 rows instead of fetching data row by row and provide it to spark so that there is improvement in select queries performance. |
-| carbon.enable.mv | true | Whether to rewrite the query plan based on the materialized views, Default value is true |
Review Comment:
its good to prepare steps. this i will handle in separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] akashrn5 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1144454845
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1124026809
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/690/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1123543321
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/689/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a diff in pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on code in PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#discussion_r873388408
##########
integration/flink/src/test/scala/org/apache/carbon/flink/TestCarbonWriter.scala:
##########
@@ -252,6 +253,7 @@ class TestCarbonWriter extends QueryTest with BeforeAndAfterAll{
assert(tables.exists(_.identifier.table.equalsIgnoreCase("mv_1")))
checkAnswer(df, Seq(Row("test99", 12345)))
checkIfStageFilesAreDeleted(tablePath)
+ sql("set carbon.enable.mv = false")
Review Comment:
better to move this under finally block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1123475810
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4554/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] akashrn5 commented on a diff in pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on code in PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#discussion_r873345558
##########
integration/spark/src/test/scala/org/apache/carbondata/view/MVTest.scala:
##########
@@ -59,54 +59,54 @@ class MVTest extends QueryTest with BeforeAndAfterAll {
sql("create table source as select * from fact_table")
sql("create materialized view mv1 as select empname, deptname, avg(salary) from source group by empname, deptname")
val df = sql("select empname, avg(salary) from source group by empname")
- assert(isTableAppearedInPlan(df.queryExecution.optimizedPlan, "mv1"))
+ assert(!isTableAppearedInPlan(df.queryExecution.optimizedPlan, "mv1"))
Review Comment:
this was to test whether hitting MV or not right? in that case need to enable here and check. Actually since in this test class, in before all better to make mv enable, so that we can avoid other changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1142310359
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/721/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1142281916
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4588/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1136116500
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4580/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4264: [CARBONDATA-4335] Disable MV by default
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on PR #4264:
URL: https://github.com/apache/carbondata/pull/4264#issuecomment-1136988926
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/716/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org