[GitHub] [druid] jihoonson commented on pull request #10307: Add support for all partitioing schemes for auto compaction

[GitBox <gi...@apache.org>]

jihoonson commented on pull request #10307:
URL: https://github.com/apache/druid/pull/10307#issuecomment-679355934


   @abhishekagarwal87 thank you for the review.
   
   > could this happen when the cluster is upgraded to newer version?
   > 
   >     * The lastCompactionState for non-dynamic partitioned segments will still be null since they were created with older version of ParallelSupervisorIndexTask but would still be compacted by the new auto compaction logic since last compaction state is null.
   
   Yes, it can happen. Since auto compaction didn't support non-dynamic partitioning before, those segments should be created by a manual compaction if they are compacted. Those segments cannot be recognized by auto compaction automatically.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org