[GitHub] [airflow] mik-laj commented on a change in pull request #5567: [AIRFLOW-4931] Add KMS Encryption Configuration to BigQuery Hook and Operators

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #5567: [AIRFLOW-4931] Add KMS Encryption Configuration to BigQuery Hook and Operators
URL: https://github.com/apache/airflow/pull/5567#discussion_r307964861
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -280,6 +282,13 @@ def create_empty_table(self,
                 "useLegacySql": False
             }
 
+        :param encryption_configuration: [Optional] Custom encryption configuration (e.g., Cloud KMS keys).
+            **Example**: ::
+
+                encryption_configuration = {
+                    "projects/testp/locations/us/keyRings/test-kr/cryptoKeys/test-key"
 
 Review comment:
   Is this the correct value for sure? I look at the documentation and it seems to me that it should be a dictionary with the key "kmsKeyName" 
   ```
         "encryptionConfiguration": { # Custom encryption configuration (e.g., Cloud KMS keys).
           "kmsKeyName": "A String", # [Optional] Describes the Cloud KMS encryption key that will be used to protect destination BigQuery table. The BigQuery Service Account associated with your project requires access to this encryption key.
         },
   ```
   Reference: 
   https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#Table
   https://cloud.google.com/bigquery/docs/reference/rest/v2/EncryptionConfiguration
   https://developers.google.com/resources/api-libraries/documentation/bigquery/v2/python/latest/bigquery_v2.tables.html#patch

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services