You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2023/04/01 09:46:13 UTC
[GitHub] [incubator-pekko] He-Pin opened a new pull request, #278: =str Implement Source.never as a dedicated GraphStage.
He-Pin opened a new pull request, #278:
URL: https://github.com/apache/incubator-pekko/pull/278
Using a more straightforward implementation will reduce the AsyncCallback in FutureSource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #278: =str Implement Source.never as a dedicated GraphStage.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #278:
URL: https://github.com/apache/incubator-pekko/pull/278#issuecomment-1497462229
> Is that a concrete concern or just a cleanup? Not sure if it is necessary to add code for a case that is only used in tests... (but also not strictly opposed).
i think this new is more easy to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin merged pull request #278: =str Implement Source.never as a dedicated GraphStage.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #278:
URL: https://github.com/apache/incubator-pekko/pull/278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on pull request #278: =str Implement Source.never as a dedicated GraphStage.
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #278:
URL: https://github.com/apache/incubator-pekko/pull/278#issuecomment-1497447947
Is that a concrete concern or just a cleanup? Not sure if it is necessary to add code for a case that is only used in tests... (but also not strictly opposed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #278: =str Implement Source.never as a dedicated GraphStage.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #278:
URL: https://github.com/apache/incubator-pekko/pull/278#issuecomment-1669547156
@mdedetrich I checked there are `NeverSourceSpec` and `never.md` already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org