You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ro...@apache.org on 2019/09/12 10:00:10 UTC
[sling-ide-tooling] branch feature/SLING-3269 created (now b39d44a)
This is an automated email from the ASF dual-hosted git repository.
rombert pushed a change to branch feature/SLING-3269
in repository https://gitbox.apache.org/repos/asf/sling-ide-tooling.git.
at b39d44a SLING-3629 - Provide an XML formatter for content.xml files
This branch includes the following new commits:
new b39d44a SLING-3629 - Provide an XML formatter for content.xml files
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[sling-ide-tooling] 01/01: SLING-3629 - Provide an XML formatter
for content.xml files
Posted by ro...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
rombert pushed a commit to branch feature/SLING-3269
in repository https://gitbox.apache.org/repos/asf/sling-ide-tooling.git
commit b39d44abec851582e441c7486c6f9354168b448c
Author: Robert Munteanu <ro...@apache.org>
AuthorDate: Thu Sep 12 11:58:19 2019 +0200
SLING-3629 - Provide an XML formatter for content.xml files
Update folling review comments from @kwin
---
eclipse/eclipse-ui/plugin.xml | 10 +++++-----
...ontentXmlResourceTester.java => DocViewResourceTester.java} | 6 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/eclipse/eclipse-ui/plugin.xml b/eclipse/eclipse-ui/plugin.xml
index 80186af..a37b1a4 100644
--- a/eclipse/eclipse-ui/plugin.xml
+++ b/eclipse/eclipse-ui/plugin.xml
@@ -427,8 +427,8 @@
id="org.apache.sling.ide.eclipse.ui.internal.ContentXmlResourceTester"
type="org.apache.sling.ide.eclipse.ui.nav.model.JcrNode"
namespace="org.apache.sling.ide.eclipse"
- properties="isContentXmlFile"
- class="org.apache.sling.ide.eclipse.ui.internal.ContentXmlResourceTester">
+ properties="isDocViewFile"
+ class="org.apache.sling.ide.eclipse.ui.internal.DocViewResourceTester">
</propertyTester>
</extension>
@@ -441,9 +441,9 @@
</iterate>
</definition>
<definition
- id="org.apache.sling.ide.eclipse.contentXmlFile">
+ id="org.apache.sling.ide.eclipse.docViewFile">
<iterate ifEmpty="false">
- <test property="org.apache.sling.ide.eclipse.isContentXmlFile"/>
+ <test property="org.apache.sling.ide.eclipse.isDocViewFile"/>
</iterate>
</definition>
<definition
@@ -580,7 +580,7 @@
label="Format .content.xml file">
<visibleWhen
checkEnabled="false">
- <reference definitionId="org.apache.sling.ide.eclipse.contentXmlFile"/>
+ <reference definitionId="org.apache.sling.ide.eclipse.docViewFile"/>
</visibleWhen>
</command>
<command
diff --git a/eclipse/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/internal/ContentXmlResourceTester.java b/eclipse/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/internal/DocViewResourceTester.java
similarity index 88%
rename from eclipse/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/internal/ContentXmlResourceTester.java
rename to eclipse/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/internal/DocViewResourceTester.java
index f0167b9..a2c4260 100644
--- a/eclipse/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/internal/ContentXmlResourceTester.java
+++ b/eclipse/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/internal/DocViewResourceTester.java
@@ -19,16 +19,16 @@ package org.apache.sling.ide.eclipse.ui.internal;
import org.apache.sling.ide.eclipse.ui.nav.model.JcrNode;
import org.eclipse.core.expressions.PropertyTester;
-public class ContentXmlResourceTester extends PropertyTester {
+public class DocViewResourceTester extends PropertyTester {
// this class should be in the core project, but since the JcrNode class is in the ui project
// we keep it here
- private static final String PN_IS_CONTENT_XML = "isContentXmlFile";
+ private static final String PN_IS_DOCVIEW_FILE = "isDocViewFile";
@Override
public boolean test(Object receiver, String property, Object[] args, Object expectedValue) {
- if (!PN_IS_CONTENT_XML.equals(property)) {
+ if (!PN_IS_DOCVIEW_FILE.equals(property)) {
return false;
}