[GitHub] [arrow] lidavidm commented on a diff in pull request #35679: GH-32276: [C++][FlightRPC] Align buffers from Flight

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #35679:
URL: https://github.com/apache/arrow/pull/35679#discussion_r1211715679


##########
cpp/src/arrow/flight/transport/grpc/serialization_internal.cc:
##########
@@ -380,6 +382,14 @@ ::grpc::Status FlightDataDeserialize(ByteBuffer* buffer,
           return ::grpc::Status(::grpc::StatusCode::INTERNAL,
                                 "Unable to read FlightData body");
         }
+        // XXX: due to where we sit, we can't use a custom allocator
+        // XXX: any error here will likely crash or hang gRPC!

Review Comment:
   This is true of any error returned here. Last I checked, gRPC doesn't actually handle errors despite this being a fallible API, instead choosing to crash.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org