You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "rnewson (via GitHub)" <gi...@apache.org> on 2023/05/22 15:07:57 UTC
[GitHub] [couchdb] rnewson opened a new pull request, #4613: optionally suppress version info in server response header
rnewson opened a new pull request, #4613:
URL: https://github.com/apache/couchdb/pull/4613
Add an option to suppress including the CouchDB and OTP versions, defaulting to the current behaviour of including both.
note: If, instead, we omitted this line we would get Mochiweb's default server line rather than no server line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #4613: optionally suppress version info in server response header
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #4613:
URL: https://github.com/apache/couchdb/pull/4613#issuecomment-1558434589
I'll merge this PR to avoid it needing another rebase + CI run wait as I have another smaller PR pending if that merged before this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a diff in pull request #4613: optionally suppress version info in server response header
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #4613:
URL: https://github.com/apache/couchdb/pull/4613#discussion_r1201222963
##########
rel/overlay/etc/default.ini:
##########
@@ -197,6 +197,10 @@ bind_address = 127.0.0.1
; the old behavior.
;bulk_get_use_batches = true
+; Whether CouchDB should send CouchDB and Erlang/OTP version in the Server
+; response header.
+; server_header_versions = true
Review Comment:
tiny nit: there shouldn't be a space after `;` for consistency with rest of the file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #4613: optionally suppress version info in server response header
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #4613:
URL: https://github.com/apache/couchdb/pull/4613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org