You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/14 04:56:45 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #4510: Rewite the
E2E test framework and tests
kezhenxu94 opened a new pull request #4510: Rewite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510
Motivation:
According the feedback from the community, the e2e tests are hard for
them to understand and get them started, so this pull request aims to
rewrite the e2e tests with some improvements:
- debuggable locally, now you can run every individual case directly
inside the IDE, just like running a plain unit test.
- same functionalities of multiple counterparts share the same codes,
case like different storages and cluster coordinators share the same
codes, easy to add more simnilar cases.
- the "end" now extends to the Doccker images, meaning that some bugs
like #4483 and #4471 can be more easily and early to be discovered.
- codes style and license headers are checked
Modifications:
- adopt jupeter (a.k.a junit 5), testcontainers as the new test
framework, all containers are orchestrated by docker-compose.yml,
well-known technology that developers should be familiar with.
- rewrite all test cases and verify them.
- reorganize the workflows in GitHub Actions.
Result:
- new e2e test should be easy to add.
- closes https://github.com/apache/skywalking/issues/4472
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4510: [WIP] Rewrite the
E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599012183
It's hard to review the diff, so just checkout the branch locally and review the final codes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2118a76250919b40e68a7a245313f8eb79ec28f7&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
=======================================
Coverage 25.50% 25.50%
=======================================
Files 1244 1244
Lines 28919 28919
Branches 3958 3958
=======================================
Hits 7375 7375
Misses 20865 20865
Partials 679 679
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [2118a76...cc4dae2](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/69e3d80e24b203bef4d86bfce2ef201a961373b0?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
==========================================
- Coverage 25.55% 25.48% -0.07%
==========================================
Files 1244 1244
Lines 28943 28926 -17
Branches 3965 3962 -3
==========================================
- Hits 7396 7372 -24
- Misses 20866 20872 +6
- Partials 681 682 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `70.73% <100%> (+0.36%)` | :arrow_up: |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `77.14% <42.85%> (-8.58%)` | :arrow_down: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...server/starter/config/ApplicationConfigLoader.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9jb25maWcvQXBwbGljYXRpb25Db25maWdMb2FkZXIuamF2YQ==) | `62.02% <0%> (-5.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [69e3d80...fc84fd5](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4510: [WIP] Rewrite the
E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d5efc97c803d3ea249a157751d6aa7af8b0fcc9b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
=======================================
Coverage 25.49% 25.49%
=======================================
Files 1244 1244
Lines 28895 28895
Branches 3953 3953
=======================================
Hits 7367 7367
Misses 20849 20849
Partials 679 679
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [d5efc97...b4d8d24](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d5efc97c803d3ea249a157751d6aa7af8b0fcc9b&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
=======================================
Coverage 25.49% 25.49%
=======================================
Files 1244 1244
Lines 28895 28895
Branches 3953 3953
=======================================
Hits 7367 7367
Misses 20849 20849
Partials 679 679
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [d5efc97...e9a7477](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4510:
[WIP] Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#discussion_r392561244
##########
File path: .github/workflows/e2e.yaml
##########
@@ -24,125 +24,97 @@ on:
tags:
- 'v*'
+env:
+ SKIP_TEST: true
+ SW_TEST_ID: ${GITHUB_RUN_ID}
+ SW_LOG_DIR: ${HOME}/logs/${GITHUB_RUN_ID}/
+
jobs:
- Single:
+ Checkstyle:
+ name: Check Codes Style
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- # In the checkout@v2, it doesn't support git submodule. Execute the commands manually.
- - name: checkout submodules
+ - name: Checkout Submodules
shell: bash
run: |
git submodule sync --recursive
git -c protocol.version=2 submodule update --init --force --recursive --depth=1
- - name: Set environment
- run: export MAVEN_OPTS='-Dmaven.repo.local=~/.m2/repository -XX:+TieredCompilation -XX:TieredStopAtLevel=1 -XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC -XX:-UseGCOverheadLimit -Xmx3g'
- - name: Compile & Install Test Codes
- run: |
- ./mvnw --batch-mode checkstyle:check apache-rat:check
- ./mvnw --batch-mode -Dcheckstyle.skip -Drat.skip -T2 -Dmaven.compile.fork -Dmaven.compiler.maxmem=3072 -DskipTests clean install
- ./mvnw --batch-mode -f test/e2e/pom.xml -pl e2e-base clean install
- - name: Single Node Tests(JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-single-service
- - name: Single Node Tests(InfluxDB/JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-influxdb
- - name: Single Node Tests(MySQL/JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-mysql
- - name: Single Node Tests(JDK9)
- run: export E2E_VERSION=jdk9-1.5 && bash -x test/e2e/run.sh e2e-single-service
- - name: Single Node Tests(JDK11)
- run: export E2E_VERSION=jdk11-1.5 && bash -x test/e2e/run.sh e2e-single-service
- - name: Single Node Tests(JDK12)
- run: export E2E_VERSION=jdk12-1.5 && bash -x test/e2e/run.sh e2e-single-service
- - name: Agent Reboot Tests(JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-agent-reboot
- - name: Agent Auth Tests(JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-agent-auth
+ - name: Checkstyle
+ run: ./mvnw --batch-mode -f test/e2e/pom.xml -DskipTests checkstyle:check
- Cluster:
+ FeaturesGroup1:
Review comment:
Once this name changed, we are facing the awkward situation. The PR can't be merged as we set that by the INFRA team. Could we consider to change it back?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4510: [WIP] Rewrite the
E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599020640
What are these? Some mistakes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/16de88c1118e240299bfb9c2fb218d73216edc3d&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
=======================================
Coverage 25.47% 25.48%
=======================================
Files 1244 1244
Lines 28918 28926 +8
Branches 3959 3962 +3
=======================================
+ Hits 7368 7372 +4
- Misses 20871 20872 +1
- Partials 679 682 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `77.14% <42.85%> (-8.58%)` | :arrow_down: |
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `70.73% <100.00%> (+0.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [16de88c...9e63c41](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4510:
[WIP] Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#discussion_r392569420
##########
File path: .github/workflows/e2e.yaml
##########
@@ -24,125 +24,97 @@ on:
tags:
- 'v*'
+env:
+ SKIP_TEST: true
+ SW_TEST_ID: ${GITHUB_RUN_ID}
+ SW_LOG_DIR: ${HOME}/logs/${GITHUB_RUN_ID}/
+
jobs:
- Single:
+ Checkstyle:
+ name: Check Codes Style
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- # In the checkout@v2, it doesn't support git submodule. Execute the commands manually.
- - name: checkout submodules
+ - name: Checkout Submodules
shell: bash
run: |
git submodule sync --recursive
git -c protocol.version=2 submodule update --init --force --recursive --depth=1
- - name: Set environment
- run: export MAVEN_OPTS='-Dmaven.repo.local=~/.m2/repository -XX:+TieredCompilation -XX:TieredStopAtLevel=1 -XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC -XX:-UseGCOverheadLimit -Xmx3g'
- - name: Compile & Install Test Codes
- run: |
- ./mvnw --batch-mode checkstyle:check apache-rat:check
- ./mvnw --batch-mode -Dcheckstyle.skip -Drat.skip -T2 -Dmaven.compile.fork -Dmaven.compiler.maxmem=3072 -DskipTests clean install
- ./mvnw --batch-mode -f test/e2e/pom.xml -pl e2e-base clean install
- - name: Single Node Tests(JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-single-service
- - name: Single Node Tests(InfluxDB/JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-influxdb
- - name: Single Node Tests(MySQL/JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-mysql
- - name: Single Node Tests(JDK9)
- run: export E2E_VERSION=jdk9-1.5 && bash -x test/e2e/run.sh e2e-single-service
- - name: Single Node Tests(JDK11)
- run: export E2E_VERSION=jdk11-1.5 && bash -x test/e2e/run.sh e2e-single-service
- - name: Single Node Tests(JDK12)
- run: export E2E_VERSION=jdk12-1.5 && bash -x test/e2e/run.sh e2e-single-service
- - name: Agent Reboot Tests(JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-agent-reboot
- - name: Agent Auth Tests(JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-agent-auth
+ - name: Checkstyle
+ run: ./mvnw --batch-mode -f test/e2e/pom.xml -DskipTests checkstyle:check
- Cluster:
+ FeaturesGroup1:
Review comment:
I am OK to change. Just we need
1. A consensus about the task lists
1. Your PR passed and ready to be merged immediately.
We could request the INFRA. Because otherwise, we can’t merge any PR if INFRA changed that before this is ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d5efc97c803d3ea249a157751d6aa7af8b0fcc9b&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
=======================================
Coverage 25.49% 25.49%
=======================================
Files 1244 1244
Lines 28895 28895
Branches 3953 3953
=======================================
Hits 7367 7367
Misses 20849 20849
Partials 679 679
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [d5efc97...f50c200](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4510: [WIP] Rewrite the
E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599012475
You need to keep name same, especially all CI required tasks. Otherwise, this can't be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: Rewrite
the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b91d7447e8f08c113236291f26cf76bd1f0a3824&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
=======================================
Coverage 25.52% 25.53%
=======================================
Files 1244 1244
Lines 28943 28951 +8
Branches 3965 3968 +3
=======================================
+ Hits 7389 7393 +4
- Misses 20873 20874 +1
- Partials 681 684 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `77.14% <42.85%> (-8.58%)` | :arrow_down: |
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `70.73% <100.00%> (+0.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [b91d744...546af83](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: Rewrite
the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b91d7447e8f08c113236291f26cf76bd1f0a3824&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
=======================================
Coverage 25.52% 25.53%
=======================================
Files 1244 1244
Lines 28943 28951 +8
Branches 3965 3968 +3
=======================================
+ Hits 7389 7392 +3
- Misses 20873 20874 +1
- Partials 681 685 +4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `77.14% <42.85%> (-8.58%)` | :arrow_down: |
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `70.73% <100.00%> (+0.36%)` | :arrow_up: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `55.00% <0.00%> (-1.67%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [b91d744...738cf41](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d5efc97c803d3ea249a157751d6aa7af8b0fcc9b&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
=======================================
Coverage 25.49% 25.49%
=======================================
Files 1244 1244
Lines 28895 28895
Branches 3953 3953
=======================================
Hits 7367 7367
Misses 20849 20849
Partials 679 679
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [d5efc97...e9a7477](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d5efc97c803d3ea249a157751d6aa7af8b0fcc9b&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
==========================================
+ Coverage 25.49% 25.51% +0.02%
==========================================
Files 1244 1244
Lines 28895 28895
Branches 3953 3953
==========================================
+ Hits 7367 7374 +7
+ Misses 20849 20842 -7
Partials 679 679
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [d5efc97...1b61105](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/69e3d80e24b203bef4d86bfce2ef201a961373b0&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
==========================================
- Coverage 25.55% 25.53% -0.02%
==========================================
Files 1244 1244
Lines 28943 28951 +8
Branches 3965 3968 +3
==========================================
- Hits 7396 7393 -3
- Misses 20866 20874 +8
- Partials 681 684 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `77.14% <42.85%> (-8.58%)` | :arrow_down: |
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `70.73% <100.00%> (+0.36%)` | :arrow_up: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [69e3d80...afe3139](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d5efc97c803d3ea249a157751d6aa7af8b0fcc9b?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
==========================================
+ Coverage 25.49% 25.51% +0.02%
==========================================
Files 1244 1244
Lines 28895 28895
Branches 3953 3953
==========================================
+ Hits 7367 7374 +7
+ Misses 20849 20842 -7
Partials 679 679
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [d5efc97...cd1867d](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4510: [WIP] Rewrite the
E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599150975
#4470 merged, so you are facing conflicts, please add this case in here too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4510: [WIP] Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#discussion_r392567933
##########
File path: .github/workflows/e2e.yaml
##########
@@ -24,125 +24,97 @@ on:
tags:
- 'v*'
+env:
+ SKIP_TEST: true
+ SW_TEST_ID: ${GITHUB_RUN_ID}
+ SW_LOG_DIR: ${HOME}/logs/${GITHUB_RUN_ID}/
+
jobs:
- Single:
+ Checkstyle:
+ name: Check Codes Style
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- # In the checkout@v2, it doesn't support git submodule. Execute the commands manually.
- - name: checkout submodules
+ - name: Checkout Submodules
shell: bash
run: |
git submodule sync --recursive
git -c protocol.version=2 submodule update --init --force --recursive --depth=1
- - name: Set environment
- run: export MAVEN_OPTS='-Dmaven.repo.local=~/.m2/repository -XX:+TieredCompilation -XX:TieredStopAtLevel=1 -XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC -XX:-UseGCOverheadLimit -Xmx3g'
- - name: Compile & Install Test Codes
- run: |
- ./mvnw --batch-mode checkstyle:check apache-rat:check
- ./mvnw --batch-mode -Dcheckstyle.skip -Drat.skip -T2 -Dmaven.compile.fork -Dmaven.compiler.maxmem=3072 -DskipTests clean install
- ./mvnw --batch-mode -f test/e2e/pom.xml -pl e2e-base clean install
- - name: Single Node Tests(JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-single-service
- - name: Single Node Tests(InfluxDB/JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-influxdb
- - name: Single Node Tests(MySQL/JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-mysql
- - name: Single Node Tests(JDK9)
- run: export E2E_VERSION=jdk9-1.5 && bash -x test/e2e/run.sh e2e-single-service
- - name: Single Node Tests(JDK11)
- run: export E2E_VERSION=jdk11-1.5 && bash -x test/e2e/run.sh e2e-single-service
- - name: Single Node Tests(JDK12)
- run: export E2E_VERSION=jdk12-1.5 && bash -x test/e2e/run.sh e2e-single-service
- - name: Agent Reboot Tests(JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-agent-reboot
- - name: Agent Auth Tests(JDK8)
- run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh e2e-agent-auth
+ - name: Checkstyle
+ run: ./mvnw --batch-mode -f test/e2e/pom.xml -DskipTests checkstyle:check
- Cluster:
+ FeaturesGroup1:
Review comment:
> Once this name changed, we are facing the awkward situation. The PR can't be merged as we set that by the INFRA team. Could we consider to change it back?
I begin to use matrix builds, so even I change back to `Single` or `Cluster`, the names are still not the same as before, besides, the original name is rather vague, and we could make it more clear, if you agree, I can open a ticket to ask the infra team for the help, to change the required statuses
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d5efc97c803d3ea249a157751d6aa7af8b0fcc9b&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
==========================================
- Coverage 25.49% 25.49% -0.01%
==========================================
Files 1244 1244
Lines 28895 28895
Branches 3953 3953
==========================================
- Hits 7367 7366 -1
Misses 20849 20849
- Partials 679 680 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `55.00% <0.00%> (-1.67%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [d5efc97...1b61105](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4510: Rewrite the E2E
test framework and tests
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4510: Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4510:
[WIP] Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#discussion_r392561300
##########
File path: test/e2e/e2e-data/src/main/resources/profiledSegment.gql
##########
@@ -1,10 +1,9 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
Review comment:
You are changing the header format, why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: Rewrite
the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b91d7447e8f08c113236291f26cf76bd1f0a3824?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
==========================================
+ Coverage 25.52% 25.56% +0.03%
==========================================
Files 1244 1244
Lines 28943 28951 +8
Branches 3965 3968 +3
==========================================
+ Hits 7389 7400 +11
+ Misses 20873 20867 -6
- Partials 681 684 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `70.73% <100%> (+0.36%)` | :arrow_up: |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `77.14% <42.85%> (-8.58%)` | :arrow_down: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [b91d744...54ac520](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/52acc6538d6df3cdd9f5ad501f4b7d50b1860268&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
==========================================
+ Coverage 25.52% 25.56% +0.03%
==========================================
Files 1244 1244
Lines 28943 28951 +8
Branches 3965 3968 +3
==========================================
+ Hits 7389 7400 +11
+ Misses 20873 20867 -6
- Partials 681 684 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `77.14% <42.85%> (-8.58%)` | :arrow_down: |
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `70.73% <100.00%> (+0.36%)` | :arrow_up: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [b91d744...5c15ca8](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d5efc97c803d3ea249a157751d6aa7af8b0fcc9b&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
=======================================
Coverage 25.49% 25.49%
=======================================
Files 1244 1244
Lines 28895 28895
Branches 3953 3953
=======================================
Hits 7367 7367
Misses 20849 20849
Partials 679 679
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [d5efc97...b4d8d24](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d5efc97c803d3ea249a157751d6aa7af8b0fcc9b?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
==========================================
+ Coverage 25.49% 25.51% +0.02%
==========================================
Files 1244 1244
Lines 28895 28895
Branches 3953 3953
==========================================
+ Hits 7367 7374 +7
+ Misses 20849 20842 -7
Partials 679 679
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [d5efc97...cd1867d](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d5efc97c803d3ea249a157751d6aa7af8b0fcc9b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
=======================================
Coverage 25.49% 25.49%
=======================================
Files 1244 1244
Lines 28895 28895
Branches 3953 3953
=======================================
Hits 7367 7367
Misses 20849 20849
Partials 679 679
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [d5efc97...1b61105](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4510: [WIP] Rewrite the
E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599408493
@wu-sheng this pull request is ready IMO, and I add it back to 7.0.0, please review and let me know if it's possible to included in 7.0.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d5efc97c803d3ea249a157751d6aa7af8b0fcc9b&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
=======================================
Coverage 25.49% 25.49%
=======================================
Files 1244 1244
Lines 28895 28895
Branches 3953 3953
=======================================
Hits 7367 7367
Misses 20849 20849
Partials 679 679
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [d5efc97...489a74c](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4510: Rewrite the E2E
test framework and tests
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4510: Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599560622
Once this PR merged, please send the notification mails to
1. Release vote as a verified result
1. Juan Pan about the update
1. Separated notification mail about the e2e framework changed totally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d5efc97c803d3ea249a157751d6aa7af8b0fcc9b&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
==========================================
+ Coverage 25.49% 25.51% +0.02%
==========================================
Files 1244 1244
Lines 28895 28895
Branches 3953 3953
==========================================
+ Hits 7367 7374 +7
+ Misses 20849 20842 -7
Partials 679 679
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [d5efc97...b4d8d24](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/69e3d80e24b203bef4d86bfce2ef201a961373b0&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
=======================================
Coverage 25.55% 25.56%
=======================================
Files 1244 1244
Lines 28943 28951 +8
Branches 3965 3968 +3
=======================================
+ Hits 7396 7400 +4
- Misses 20866 20867 +1
- Partials 681 684 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `77.14% <42.85%> (-8.58%)` | :arrow_down: |
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `70.73% <100.00%> (+0.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [69e3d80...bbe9a36](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/69e3d80e24b203bef4d86bfce2ef201a961373b0&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
==========================================
- Coverage 25.55% 25.53% -0.02%
==========================================
Files 1244 1244
Lines 28943 28951 +8
Branches 3965 3968 +3
==========================================
- Hits 7396 7393 -3
- Misses 20866 20874 +8
- Partials 681 684 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `77.14% <42.85%> (-8.58%)` | :arrow_down: |
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `70.73% <100.00%> (+0.36%)` | :arrow_up: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [69e3d80...afe3139](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4510: [WIP]
Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599017851
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=h1) Report
> Merging [#4510](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d5efc97c803d3ea249a157751d6aa7af8b0fcc9b?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4510 +/- ##
==========================================
+ Coverage 25.49% 25.51% +0.02%
==========================================
Files 1244 1244
Lines 28895 28895
Branches 3953 3953
==========================================
+ Hits 7367 7374 +7
+ Misses 20849 20842 -7
Partials 679 679
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4510/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=footer). Last update [d5efc97...2f458a3](https://codecov.io/gh/apache/skywalking/pull/4510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4510: [WIP] Rewrite the E2E test framework and tests
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4510: [WIP] Rewrite the E2E test framework and tests
URL: https://github.com/apache/skywalking/pull/4510#discussion_r392562383
##########
File path: test/e2e/e2e-data/src/main/resources/profiledSegment.gql
##########
@@ -1,10 +1,9 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
Review comment:
> You are changing the header format, why?
The license headers in such kind of files are checked by Checkstyle plugin, by matching regular expression, so, have to
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services