You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tamaya.apache.org by peculater <gi...@git.apache.org> on 2018/02/01 03:38:00 UTC

[GitHub] incubator-tamaya pull request #10: TAMAYA-326: Fix bug in ordinal comparison...

GitHub user peculater opened a pull request:

    https://github.com/apache/incubator-tamaya/pull/10

    TAMAYA-326: Fix bug in ordinal comparison in ServiceContextManager

    While adding some test coverage on the api, I found that
    org.apache.tamaya.spi.ServiceContextManager has a bug as it searches for
    the default service provider in loadDefaultServiceProvider.  Namely, the
    "highestOrdinal" is not set after the first service provider is found,
    so any following service provider with an ordinal higher than 0 will be
    used, even if that ordinal is lower than the first one's.  This patch
    fixes the logic, and adds tests to cover the case.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/peculater/incubator-tamaya TAMAYA-326

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tamaya/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit 135792e9f649693684d85d68b83a6a258e782a10
Author: William Lieurance <wi...@...>
Date:   2018-02-01T03:36:41Z

    TAMAYA-326: Fix bug in ordinal comparison in ServiceContextManager
    
    While adding some test coverage on the api, I found that
    org.apache.tamaya.spi.ServiceContextManager has a bug as it searches for
    the default service provider in loadDefaultServiceProvider.  Namely, the
    "highestOrdinal" is not set after the first service provider is found,
    so any following service provider with an ordinal higher than 0 will be
    used, even if that ordinal is lower than the first one's.  This patch
    fixes the logic, and adds tests to cover the case.

----


---

[GitHub] incubator-tamaya pull request #10: TAMAYA-326: Fix bug in ordinal comparison...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-tamaya/pull/10


---