[GitHub] ctubbsii commented on a change in pull request #524: Tiered Volume Chooser, including Regex and Default strategies.

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #524: Tiered Volume Chooser, including Regex and Default strategies.
URL: https://github.com/apache/accumulo/pull/524#discussion_r193885812
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/fs/DefaultTieredStorageStrategy.java
 ##########
 @@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.accumulo.server.fs;
+
+import org.apache.accumulo.server.conf.ServerConfigurationFactory;
+import org.apache.accumulo.server.conf.TableConfiguration;
+
+public class DefaultTieredStorageStrategy implements TieredStorageStrategy {
+  @Override
+  public String getVolumeList(VolumeChooserEnvironment env, ServerConfigurationFactory confFactory,
 
 Review comment:
   A method called `get...List` should probably return a list.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services