You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Samuel Guo (JIRA)" <ji...@apache.org> on 2009/02/18 03:27:01 UTC
[jira] Created: (HAMA-153) Need some condition-check before matrix
algebra
Need some condition-check before matrix algebra
-----------------------------------------------
Key: HAMA-153
URL: https://issues.apache.org/jira/browse/HAMA-153
Project: Hama
Issue Type: Bug
Components: implementation
Reporter: Samuel Guo
Priority: Minor
some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
for examples,
A + B, we need check that A.rows = B.rows & A.columns = B.columns
A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-153) Need some condition-check before matrix
algebra
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-153:
--------------------------------
Attachment: HAMA-153_v03.patch
if(this.getRows() < row)
increaseRows();
will be better.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Reporter: Samuel Guo
> Priority: Minor
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-153) Need some condition-check before matrix
algebra
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-153:
----------------------------
Status: Open (was: Patch Available)
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch, HAMA-153_v04.patch, HAMA-153_v05.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-153) Need some condition-check before
matrix algebra
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675283#action_12675283 ]
Hudson commented on HAMA-153:
-----------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12400400/HAMA-153_v04.patch
against trunk revision 744798.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
patch -1. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/156/console
This message is automatically generated.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch, HAMA-153_v04.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-153) Need some condition-check before
matrix algebra
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675292#action_12675292 ]
Edward J. Yoon commented on HAMA-153:
-------------------------------------
Samuel, your patch seems buggy.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch, HAMA-153_v04.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-153) Need some condition-check before matrix
algebra
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-153:
----------------------------
Status: Patch Available (was: Open)
try it.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Reporter: Samuel Guo
> Priority: Minor
> Attachments: HAMA-153.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-153) Need some condition-check before
matrix algebra
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674494#action_12674494 ]
Hudson commented on HAMA-153:
-----------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12400389/HAMA-153.patch
against trunk revision 744798.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests -1. The patch failed core unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/154/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/154/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/154/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/154/console
This message is automatically generated.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Reporter: Samuel Guo
> Priority: Minor
> Attachments: HAMA-153.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-153) Need some condition-check before
matrix algebra
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674523#action_12674523 ]
Hudson commented on HAMA-153:
-----------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12400395/HAMA-153_v03.patch
against trunk revision 744798.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/155/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/155/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/155/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/155/console
This message is automatically generated.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-153) Need some condition-check before matrix
algebra
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-153:
----------------------------
Attachment: HAMA-153.patch
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Reporter: Samuel Guo
> Priority: Minor
> Attachments: HAMA-153.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-153) Need some condition-check before matrix
algebra
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-153:
--------------------------------
Status: Patch Available (was: Open)
Rescheduling for hudson +1
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch, HAMA-153_v04.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-153) Need some condition-check before matrix
algebra
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-153:
----------------------------
Status: Patch Available (was: Open)
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch, HAMA-153_v04.patch, HAMA-153_v05.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-153) Need some condition-check before matrix
algebra
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-153:
--------------------------------
Attachment: HAMA-153_v02.patch
I found another bug. If we add new vector to matrix, the metadata of dimensions should be increased.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Reporter: Samuel Guo
> Priority: Minor
> Attachments: HAMA-153.patch, HAMA-153_v02.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-153) Need some condition-check before
matrix algebra
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674550#action_12674550 ]
Edward J. Yoon commented on HAMA-153:
-------------------------------------
As you said, matrix addition require the conformability. So, your patch looks great.
>> BTW, should we need a test case for addition-check?
If we add a test case for it, I would believe we can find more easily an related code bugs.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch, HAMA-153_v04.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-153) Need some condition-check before matrix
algebra
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-153:
--------------------------------
Status: Open (was: Patch Available)
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch, HAMA-153_v04.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-153) Need some condition-check before
matrix algebra
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674533#action_12674533 ]
Samuel Guo commented on HAMA-153:
---------------------------------
thank you, edward.
BTW, should we need a test case for addition-check?
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-153) Need some condition-check before matrix
algebra
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-153:
--------------------------------
Fix Version/s: 0.1.0
Affects Version/s: 0.1.0
Status: Patch Available (was: Open)
Submit to hudson.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-153) Need some condition-check before matrix
algebra
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-153:
----------------------------
Attachment: HAMA-153_v04.patch
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch, HAMA-153_v04.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-153) Need some condition-check before matrix
algebra
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-153:
----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
It seems that the patch is OK.
I just commit this.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch, HAMA-153_v04.patch, HAMA-153_v05.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-153) Need some condition-check before
matrix algebra
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674506#action_12674506 ]
Edward J. Yoon commented on HAMA-153:
-------------------------------------
It'll need a test case.
TestDenseMatrix.testSetRow/Column() will increase the size of row/column.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Reporter: Samuel Guo
> Priority: Minor
> Attachments: HAMA-153.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-153) Need some condition-check before matrix
algebra
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-153:
--------------------------------
Status: Open (was: Patch Available)
Rescheduling.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Reporter: Samuel Guo
> Priority: Minor
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-153) Need some condition-check before
matrix algebra
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675724#action_12675724 ]
Hudson commented on HAMA-153:
-----------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12400687/HAMA-153_v05.patch
against trunk revision 744798.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/157/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/157/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/157/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/157/console
This message is automatically generated.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch, HAMA-153_v04.patch, HAMA-153_v05.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-153) Need some condition-check before matrix
algebra
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-153:
----------------------------
Attachment: HAMA-153_v05.patch
try again.
> Need some condition-check before matrix algebra
> -----------------------------------------------
>
> Key: HAMA-153
> URL: https://issues.apache.org/jira/browse/HAMA-153
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Samuel Guo
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-153.patch, HAMA-153_v02.patch, HAMA-153_v03.patch, HAMA-153_v04.patch, HAMA-153_v05.patch
>
>
> some conditions will be checked before we construct the result matrix and compose the matrix algebra map/reduce job.
> for examples,
> A + B, we need check that A.rows = B.rows & A.columns = B.columns
> A * B, we need check that A.columns = B.rows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.