[GitHub] [airflow] vanchaxy commented on pull request #24342: KubernetesExecutor: Always give precedence to pod from executor_config arg

[GitBox <gi...@apache.org>]

vanchaxy commented on PR #24342:
URL: https://github.com/apache/airflow/pull/24342#issuecomment-1152813887

   Hi, I also encountered this bug. For now, I overcome it with pod_hook. 
   
   From what I see, at the start of the construct_pod (line 339) we check for the image in pod_override_object and use it in kube_image.
   This should be removed if we change the order of pods as you did in this PR or the namespace should be overwritten in a similar way.
   
   I see the problem that after this PR users of airflow can overwrite some important annotations/labels which airflow use to operate and this will break executor work.
   
   My suggestion is:
   1) Remove image overwriting at the start of the function (try... except block)
   2) Split dynamic_pod into 2 different pods.  One with namespace and kube_image. Another with annotations/labels/name/args/env.
   3) Change pod_list order to pod_template_file -> pod with namespace and image ->  pod from executor_config -> pod from from dynamic arguments (annotations/labels/...).
   
   After this change, we will have two dynamic pods: one with values that we allow users to overwrite and another with values that should not be overwritten by users.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org