You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Ken Howe <kh...@pivotal.io> on 2017/03/13 22:31:16 UTC
Re: Review Request 57522: check for string "null" in server/locator
status message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57522/
-----------------------------------------------------------
(Updated March 13, 2017, 10:31 p.m.)
Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Kirk Lund, Patrick Rhomberg, and Swapnil Bawaskar.
Summary (updated)
-----------------
check for string "null" in server/locator status message
Repository: geode
Description (updated)
-------
Restored original functionality when launcher process exits. Unintentionally omitted this when refactoring from using exitValue() to isAlive()
Check for string "null" in server/locator status message to prevent interrupting the string of dots.
Refactored server and locator start commands to use JDK 1.8 Process.isAlive instead of a try/catch with Process.exitValue
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java d42d75e
Diff: https://reviews.apache.org/r/57522/diff/2/
Changes: https://reviews.apache.org/r/57522/diff/1-2/
Testing (updated)
-------
Ran spotlessApply
Re-started precheckin
Thanks,
Ken Howe
Re: Review Request 57522: check for string "null" in server/locator
status message
Posted by Kevin Duling <kd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57522/#review168841
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Duling
On March 13, 2017, 3:31 p.m., Ken Howe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57522/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 3:31 p.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Kirk Lund, Patrick Rhomberg, and Swapnil Bawaskar.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Restored original functionality when launcher process exits. Unintentionally omitted this when refactoring from using exitValue() to isAlive()
>
> Check for string "null" in server/locator status message to prevent interrupting the string of dots.
>
> Refactored server and locator start commands to use JDK 1.8 Process.isAlive instead of a try/catch with Process.exitValue
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java d42d75e
>
>
> Diff: https://reviews.apache.org/r/57522/diff/2/
>
>
> Testing
> -------
>
> Ran spotlessApply
> Re-started precheckin
>
>
> Thanks,
>
> Ken Howe
>
>
Re: Review Request 57522: check for string "null" in server/locator
status message
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57522/#review168909
-----------------------------------------------------------
Ship it!
Ship It!
- Jared Stewart
On March 13, 2017, 10:31 p.m., Ken Howe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57522/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 10:31 p.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Kirk Lund, Patrick Rhomberg, and Swapnil Bawaskar.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Restored original functionality when launcher process exits. Unintentionally omitted this when refactoring from using exitValue() to isAlive()
>
> Check for string "null" in server/locator status message to prevent interrupting the string of dots.
>
> Refactored server and locator start commands to use JDK 1.8 Process.isAlive instead of a try/catch with Process.exitValue
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java d42d75e
>
>
> Diff: https://reviews.apache.org/r/57522/diff/2/
>
>
> Testing
> -------
>
> Ran spotlessApply
> Re-started precheckin
>
>
> Thanks,
>
> Ken Howe
>
>
Re: Review Request 57522: check for string "null" in server/locator
status message
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57522/#review170020
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On March 13, 2017, 10:31 p.m., Ken Howe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57522/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 10:31 p.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Kirk Lund, Patrick Rhomberg, and Swapnil Bawaskar.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Restored original functionality when launcher process exits. Unintentionally omitted this when refactoring from using exitValue() to isAlive()
>
> Check for string "null" in server/locator status message to prevent interrupting the string of dots.
>
> Refactored server and locator start commands to use JDK 1.8 Process.isAlive instead of a try/catch with Process.exitValue
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java d42d75e
>
>
> Diff: https://reviews.apache.org/r/57522/diff/2/
>
>
> Testing
> -------
>
> Ran spotlessApply
> Re-started precheckin
>
>
> Thanks,
>
> Ken Howe
>
>