You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/01/26 00:55:00 UTC
Review Request 55968: Added TODOs to make the master code safer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55968/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
The executor and tasks fields in the master's structs for agents
and frameworks are publicly visible, but yet for correctness it
is required that callers made modifications through the member
functions which carry additional logic (e.g. tracking allocated
resources). The TODO here is to make these private and to provide
public views that are const.
Diffs
-----
src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b
Diff: https://reviews.apache.org/r/55968/diff/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 55968: Added TODOs to make the master code safer.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55968/#review163401
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On \u4e00\u6708 26, 2017, 12:55 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55968/
> -----------------------------------------------------------
>
> (Updated \u4e00\u6708 26, 2017, 12:55 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The executor and tasks fields in the master's structs for agents
> and frameworks are publicly visible, but yet for correctness it
> is required that callers made modifications through the member
> functions which carry additional logic (e.g. tracking allocated
> resources). The TODO here is to make these private and to provide
> public views that are const.
>
>
> Diffs
> -----
>
> src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b
>
> Diff: https://reviews.apache.org/r/55968/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>