[Bug 66047] Rounding issue in MROUND due to 1897066

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=66047

--- Comment #3 from Fabio <fa...@dvbern.ch> ---
Hi

I have second thoughts about the rounding improvements in
https://svn.apache.org/viewvc?view=revision&revision=1897066.

My patch does solve some cases, but it also does something different than the
excel implementation. With my patch, the example of MS' "Known Limitations"
breaks. Both, 6.05 and 7.05 are now rounded deterministically to 6.1
respectively 7.1. The example from Microsoft rounds to 6.0 and 7.1.

In my opinion, consistent rounding is definitely better, but then the POI
implementation is not consistent with Excel :-(
Finding quirks to accommodate for Excel's undefined behaviour is error prone
and unmaintainable.

I don't know what's the best way forward here. Reverting 1897066 is probably
not an option either, is it?

[1]
https://support.microsoft.com/en-us/office/mround-function-c299c3b0-15a5-426d-aa4b-d2d5b3baf427

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org