You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Ramin Moazeni (JIRA)" <ji...@apache.org> on 2007/06/21 19:36:25 UTC
[jira] Created: (DERBY-2855) Convert
jdbc4/TestConnectionMethods.java to JUnit
Convert jdbc4/TestConnectionMethods.java to JUnit
-------------------------------------------------
Key: DERBY-2855
URL: https://issues.apache.org/jira/browse/DERBY-2855
Project: Derby
Issue Type: Bug
Components: Test
Affects Versions: 10.3.0.0
Reporter: Ramin Moazeni
Assignee: Ramin Moazeni
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2855) Convert
jdbc4/TestConnectionMethods.java to JUnit
Posted by "Ramin Moazeni (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramin Moazeni updated DERBY-2855:
---------------------------------
Attachment: DERBY-2855v1.stat
DERBY-2855v1.diff
Hi Kathey
Attachment please find the v1 patch that addresses your comments.
I tried this on WinXP and the error messages you reported are
resolved now.
I appreciate your comments.
Thanks
Ramin
> Convert jdbc4/TestConnectionMethods.java to JUnit
> -------------------------------------------------
>
> Key: DERBY-2855
> URL: https://issues.apache.org/jira/browse/DERBY-2855
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.1.4
> Reporter: Ramin Moazeni
> Assignee: Ramin Moazeni
> Attachments: DERBY-2855v0.diff, DERBY-2855v0.stat, DERBY-2855v1.diff, DERBY-2855v1.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2855) Convert
jdbc4/TestConnectionMethods.java to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520652 ]
Kathey Marsden commented on DERBY-2855:
---------------------------------------
Hi Ramin,
Here are some comments. Some are related to the original test, but I think are worth pursuing now.
When I ran the test it failed with:
junit.framework.AssertionFailedError: extin\short.txt
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at org.apache.derbyTesting.junit.DropDatabaseSetup.removeDir(DropDatabaseSetup.java:129)
at org.apache.derbyTesting.junit.DropDatabaseSetup.access$000(DropDatabaseSetup.java:38)
at org.apache.derbyTesting.junit.DropDatabaseSetup$1.run(DropDatabaseSetup.java:104)
at java.security.AccessController.doPrivileged(Native Method)
at org.apache.derbyTesting.junit.DropDatabaseSetup.removeDirectory(DropDatabaseSetup.java:101)
at org.apache.derbyTesting.junit.SupportFilesSetup.tearDown(SupportFilesSetup.java:126)
at junit.extensions.TestSetup$1.protect(TestSetup.java:20)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.extensions.TestSetup.run(TestSetup.java:23)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.extensions.TestSetup.run(TestSetup.java:23)
at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.extensions.TestSetup.run(TestSetup.java:23)
at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.extensions.TestSetup.run(TestSetup.java:23)
at junit.framework.TestSuite.runTest(TestSuite.java:208)
at junit.framework.TestSuite.run(TestSuite.java:203)
at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:128)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)
The methods to start and stop network server are just shutting down the database and reconnecting. They should
be starting and stopping network server using the NetworkServerControl interface. It would be good to add methods to
TestConfiguration for startNetworkServer and stopNetworkServer
The support file short.txt should not be under the ImportExport directory but in a directory called Clob or ConnectionMethods or something more relevant.
The following issues are from the original test.
Would it be possible for us to change testCreate{C|B}lobClient to just be testCreate{C|B}lob and run for both embedded and client?
We should be checking the contents of the clob/bob that we insert.
> Convert jdbc4/TestConnectionMethods.java to JUnit
> -------------------------------------------------
>
> Key: DERBY-2855
> URL: https://issues.apache.org/jira/browse/DERBY-2855
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.1.4
> Reporter: Ramin Moazeni
> Assignee: Ramin Moazeni
> Attachments: DERBY-2855v0.diff, DERBY-2855v0.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2855) Convert
jdbc4/TestConnectionMethods.java to JUnit
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren resolved DERBY-2855.
---------------------------------------
Resolution: Fixed
Fix Version/s: 10.4.0.0
> Convert jdbc4/TestConnectionMethods.java to JUnit
> -------------------------------------------------
>
> Key: DERBY-2855
> URL: https://issues.apache.org/jira/browse/DERBY-2855
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.1.4
> Reporter: Ramin Moazeni
> Assignee: Ramin Moazeni
> Fix For: 10.4.0.0
>
> Attachments: DERBY-2855v0.diff, DERBY-2855v0.stat, DERBY-2855v1.diff, DERBY-2855v1.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2855) Convert
jdbc4/TestConnectionMethods.java to JUnit
Posted by "Ramin Moazeni (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramin Moazeni updated DERBY-2855:
---------------------------------
Attachment: DERBY-2855v0.stat
DERBY-2855v0.diff
Hello
I am attaching an interim patch with this issue.
I appreciate your comments/review.
Thanks
Ramin Moazeni
> Convert jdbc4/TestConnectionMethods.java to JUnit
> -------------------------------------------------
>
> Key: DERBY-2855
> URL: https://issues.apache.org/jira/browse/DERBY-2855
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.1.4
> Reporter: Ramin Moazeni
> Assignee: Ramin Moazeni
> Attachments: DERBY-2855v0.diff, DERBY-2855v0.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2855) Convert
jdbc4/TestConnectionMethods.java to JUnit
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan closed DERBY-2855.
----------------------------------
I believe this issue has been completed. Closing.
> Convert jdbc4/TestConnectionMethods.java to JUnit
> -------------------------------------------------
>
> Key: DERBY-2855
> URL: https://issues.apache.org/jira/browse/DERBY-2855
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.1.4
> Reporter: Ramin Moazeni
> Assignee: Ramin Moazeni
> Fix For: 10.4.1.3
>
> Attachments: DERBY-2855v0.diff, DERBY-2855v0.stat, DERBY-2855v1.diff, DERBY-2855v1.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2855) Convert
jdbc4/TestConnectionMethods.java to JUnit
Posted by "Ramin Moazeni (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520634 ]
Ramin Moazeni commented on DERBY-2855:
--------------------------------------
Hi Kathey
I don't think anything needs to be added. I was not sure if
assertStartNetworkServerOK() is implemented correctly.
Thanks
Ramin
> Convert jdbc4/TestConnectionMethods.java to JUnit
> -------------------------------------------------
>
> Key: DERBY-2855
> URL: https://issues.apache.org/jira/browse/DERBY-2855
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.1.4
> Reporter: Ramin Moazeni
> Assignee: Ramin Moazeni
> Attachments: DERBY-2855v0.diff, DERBY-2855v0.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2855) Convert
jdbc4/TestConnectionMethods.java to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520626 ]
Kathey Marsden commented on DERBY-2855:
---------------------------------------
Ramin, could you explain why this is an interim patch. What else needs to be added for commit?
> Convert jdbc4/TestConnectionMethods.java to JUnit
> -------------------------------------------------
>
> Key: DERBY-2855
> URL: https://issues.apache.org/jira/browse/DERBY-2855
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.1.4
> Reporter: Ramin Moazeni
> Assignee: Ramin Moazeni
> Attachments: DERBY-2855v0.diff, DERBY-2855v0.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2855) Convert
jdbc4/TestConnectionMethods.java to JUnit
Posted by "Daniel John Debrunner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel John Debrunner updated DERBY-2855:
-----------------------------------------
Issue Type: Task (was: Bug)
> Convert jdbc4/TestConnectionMethods.java to JUnit
> -------------------------------------------------
>
> Key: DERBY-2855
> URL: https://issues.apache.org/jira/browse/DERBY-2855
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Ramin Moazeni
> Assignee: Ramin Moazeni
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.