You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2017/03/31 13:31:03 UTC
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6524
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
IMPALA-4733: Change HBase ports to non-ephemeral
Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
---
M fe/src/test/resources/hbase-site.xml.template
M testdata/cluster/admin
M testdata/cluster/node_templates/cdh5/etc/init.d/kms
3 files changed, 24 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/6524/1
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
Patch Set 3:
(1 comment)
Thank you for the review. Please see my comment and the new PS3.
http://gerrit.cloudera.org:8080/#/c/6524/2/testdata/cluster/node_templates/cdh5/etc/init.d/kms
File testdata/cluster/node_templates/cdh5/etc/init.d/kms:
Line 25: export KMS_HTTP_PORT=$KMS_WEBUI_PORT
> How did it work before? Was it picking the default port or something?
Yes, this was leaving the default port unchanged, which was 16000. I updated the commit message to highlight the changes to the ports.
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
Patch Set 3:
> Mike, did you have any objections to this change or are you mostly
> asking for confirmation that IMPALA-4733 is fixed?
I was mostly asking for confirmation that IMPALA-4733 is fixed.
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
Patch Set 4: Code-Review+2
Thanks for the reviews! I rebased the change and will start the submit job next. Carrying Alex's +2.
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
Patch Set 4:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/433/
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
IMPALA-4733: Change HBase ports to non-ephemeral
We've seen repeated test failures because HBase tries to bind to ports
in the ephemeral port range, which sometimes would already be occupied
by outgoing connections of other proccesses.
This change changes the ports to the new default HBase ports
(HBASE-10123):
HBase Master Port: 60000 -> 16000
HBase Master Web UI Port: 60010 -> 16010
HBase ReqionServer Port: 60020 -> 16020
HBase ReqionServer Web UI Port: 60030 -> 16030
HBase Status Multicast Port: 60100 -> 16100
This made it necessary to change the default KMS port, too
(HADOOP-12811):
KMS HTTP port: 16000 -> 9600
Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Reviewed-on: http://gerrit.cloudera.org:8080/6524
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/test/resources/hbase-site.xml.template
M testdata/cluster/admin
M testdata/cluster/node_templates/cdh5/etc/init.d/kms
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.tmpl
M testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl
5 files changed, 32 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Lars Volker: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
Patch Set 3: Code-Review+1
Having fixed ports makes sense to me regardless of whether it fixes IMPALA-4733, but I do hope it fixes that as well.
Mike, did you have any objections to this change or are you mostly asking for confirmation that IMPALA-4733 is fixed?
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6524
to look at the new patch set (#3).
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
IMPALA-4733: Change HBase ports to non-ephemeral
We've seen repeated test failures because HBase tries to bind to ports
in the ephemeral port range, which sometimes would already be occupied
by outgoing connections of other proccesses.
This change changes the ports to the new default HBase ports
(HBASE-10123):
HBase Master Port: 60000 -> 16000
HBase Master Web UI Port: 60010 -> 16010
HBase ReqionServer Port: 60020 -> 16020
HBase ReqionServer Web UI Port: 60030 -> 16030
HBase Status Multicast Port: 60100 -> 16100
This made it necessary to change the default KMS port, too
(HADOOP-12811):
KMS HTTP port: 16000 -> 9600
Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
---
M fe/src/test/resources/hbase-site.xml.template
M testdata/cluster/admin
M testdata/cluster/node_templates/cdh5/etc/init.d/kms
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.tmpl
M testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl
5 files changed, 32 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/6524/3
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
Patch Set 3:
> Can you report how you tested this, and if it works on RHEL 7
> consistently enough that IMPALA-4733 has gone away?
I tested this locally by starting the minicluster on my dev machine, and I'm running a private exhaustive build on Cloudera's internal Jenkins. I couldn't find a way to make sure this fixes the RHEL7 issues, but it seems reasonable to assume that they were caused by HBase trying to bind ports in the ephemeral port range. If this passes the internal exhaustive build, I'd be willing to give it a try and see if the RHEL7 tests improve.
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6524/2/testdata/cluster/node_templates/cdh5/etc/init.d/kms
File testdata/cluster/node_templates/cdh5/etc/init.d/kms:
Line 25: export KMS_HTTP_PORT=$KMS_WEBUI_PORT
How did it work before? Was it picking the default port or something?
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
Patch Set 2:
Can you report how you tested this, and if it works on RHEL 7 consistently enough that IMPALA-4733 has gone away?
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
IMPALA-4733: Change HBase ports to non-ephemeral
Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
---
M fe/src/test/resources/hbase-site.xml.template
M testdata/cluster/admin
M testdata/cluster/node_templates/cdh5/etc/init.d/kms
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.tmpl
M testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl
5 files changed, 26 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/6524/2
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-4733: Change HBase ports to non-ephemeral
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-4733: Change HBase ports to non-ephemeral
......................................................................
Patch Set 3:
A private exhaustive build passed for PS2. I made the additional change to the HBase multicast port for sake of completeness, but afaik we don't use that anyways. This should be good. :)
--
To view, visit http://gerrit.cloudera.org:8080/6524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8af325e34b6e352afd75ce5ddd2446ce73d857
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No