You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/11/25 20:06:45 UTC
[kudu-CR] [WIP] try checkstyle excludes
Jordan Birdsell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5225
Change subject: [WIP] try checkstyle excludes
......................................................................
[WIP] try checkstyle excludes
Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
---
M java/pom.xml
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/5225/1
--
To view, visit http://gerrit.cloudera.org:8080/5225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
[kudu-CR] [build] - Suppress generated sources from checkstyle plugin
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5225
to look at the new patch set (#6).
Change subject: [build] - Suppress generated sources from checkstyle plugin
......................................................................
[build] - Suppress generated sources from checkstyle plugin
The Maven Checkstyle plugin is currently executing against
generated sources, this patch uses a Suppression Filter to
avoid this.
Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
---
A java/checkstyle-suppressions.xml
M java/kudu_style.xml
M java/pom.xml
3 files changed, 33 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/5225/6
--
To view, visit http://gerrit.cloudera.org:8080/5225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [WIP] try checkstyle excludes
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has uploaded a new patch set (#2).
Change subject: [WIP] try checkstyle excludes
......................................................................
[WIP] try checkstyle excludes
Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
---
M java/pom.xml
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/5225/2
--
To view, visit http://gerrit.cloudera.org:8080/5225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [build] - Suppress generated sources from checkstyle plugin
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [build] - Suppress generated sources from checkstyle plugin
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [build] - Suppress generated sources from checkstyle plugin
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5225
to look at the new patch set (#7).
Change subject: [build] - Suppress generated sources from checkstyle plugin
......................................................................
[build] - Suppress generated sources from checkstyle plugin
The Maven Checkstyle plugin is currently executing against
generated sources, this patch uses a Suppression Filter to
avoid this.
Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
---
A java/checkstyle_suppressions.xml
M java/kudu_style.xml
M java/pom.xml
3 files changed, 33 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/5225/7
--
To view, visit http://gerrit.cloudera.org:8080/5225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [WIP] try checkstyle excludes
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5225
to look at the new patch set (#4).
Change subject: [WIP] try checkstyle excludes
......................................................................
[WIP] try checkstyle excludes
Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
---
M java/pom.xml
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/5225/4
--
To view, visit http://gerrit.cloudera.org:8080/5225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [WIP] try checkstyle excludes
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5225
to look at the new patch set (#5).
Change subject: [WIP] try checkstyle excludes
......................................................................
[WIP] try checkstyle excludes
Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
---
A java/checkstyle-suppressions.xml
M java/kudu_style.xml
M java/pom.xml
3 files changed, 33 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/5225/5
--
To view, visit http://gerrit.cloudera.org:8080/5225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [WIP] try checkstyle excludes
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5225
to look at the new patch set (#3).
Change subject: [WIP] try checkstyle excludes
......................................................................
[WIP] try checkstyle excludes
Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
---
M java/pom.xml
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/5225/3
--
To view, visit http://gerrit.cloudera.org:8080/5225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [build] - Suppress generated sources from checkstyle plugin
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: [build] - Suppress generated sources from checkstyle plugin
......................................................................
[build] - Suppress generated sources from checkstyle plugin
The Maven Checkstyle plugin is currently executing against
generated sources, this patch uses a Suppression Filter to
avoid this.
Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
Reviewed-on: http://gerrit.cloudera.org:8080/5225
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
A java/checkstyle_suppressions.xml
M java/kudu_style.xml
M java/pom.xml
3 files changed, 33 insertions(+), 4 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>