You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/09 12:08:00 UTC
[jira] [Commented] (FLINK-9319) Move some flink-docs dependencies
into profiles
[ https://issues.apache.org/jira/browse/FLINK-9319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468754#comment-16468754 ]
ASF GitHub Bot commented on FLINK-9319:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5974
[FLINK-9319][docs] Move reflection dependencies into profile
## What is the purpose of the change
This PR moves dependencies of `flink-docs` that are only accessed via reflection by the config docs generator into the `generate-config-docs` profile. This makes the generation of the rest docs faster/more convenient since we can skip a few modules.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9319
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5974.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5974
----
commit e4da2f8af23b1fbaa16205108895f5296a987d54
Author: zentol <ch...@...>
Date: 2018-05-09T08:53:22Z
[FLINK-9319][docs] Move reflection dependencies into profile
----
> Move some flink-docs dependencies into profiles
> -----------------------------------------------
>
> Key: FLINK-9319
> URL: https://issues.apache.org/jira/browse/FLINK-9319
> Project: Flink
> Issue Type: Improvement
> Components: Build System, Documentation
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Trivial
> Fix For: 1.5.0
>
>
> The config docs generator loads classes from various modules (runtime/mesos/yarn) via reflection. These classes aren't necessary for compilation, but only when actuall running the generator.
> We can move these dependencies into the {{generate-config-docs}} profile.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)