You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/13 16:31:58 UTC
[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7095: fix guestOsMapper and move mapping code to latest upgrade
DaanHoogland opened a new pull request, #7095:
URL: https://github.com/apache/cloudstack/pull/7095
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1384027827
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1396845044
@weizhouapache should I rebase on 4.17?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1384758686
<b>Trillian test result (tid-5868)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46615 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7095-t5868-kvm-centos7.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1387291356
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1398173473
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1398334881
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1398235490
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1396911454
> > @weizhouapache should I rebase on 4.17?
>
> @DaanHoogland
>
> it will be complicated ...
>
> you need to
> (1) add upgrade path 4.17.2.0->4.17.3.0
> (2) move everything to Upgrade41720to41730.java
>
> and
> what if there is not 4.17.3.0 release ?
> what if 4.17.3.0 is released after 4.18.0.0, can upgrade from 4.17.3.0 to 4.18.0.0 ?
> we may need to keep the codes in both files: Upgrade41720to41730.java and Upgrade41720to41800.java
And merge forward guaranteed conflicts. Let's leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1384028813
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1385447208
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7095)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7095&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7095&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7095&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=CODE_SMELL) [36 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_coverage&view=list) [0.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_duplicated_lines_density&view=list) [84.7% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1396759510
> LGTM @DaanHoogland would we need to do that with every release?
if we will do another 4.17 minor release (4.17.3.0), we need to fix in 4.17 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#discussion_r1071041529
##########
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41500to41510.java:
##########
@@ -250,130 +249,6 @@ private void correctGuestOsNames(final Connection conn) {
guestOsMapper.updateGuestOsNameFromMapping("OpenSUSE Linux (32 bit)", mapping);
}
Review Comment:
double-checked just now.
both `addGuestOsAndHypervisorMappings` and `updateGuestOsIdInHypervisorMapping` call the method `getGuestOsId`, they need to be moved.
`updateGuestOsNameFromMapping` is correct. sorry for my mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1385542392
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7095](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8e54f07) into [main](https://codecov.io/gh/apache/cloudstack/commit/566578297b6164fc1e9f8a2b3ea38789b459fd7a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5665782) will **increase** coverage by `0.00%`.
> The diff coverage is `0.37%`.
```diff
@@ Coverage Diff @@
## main #7095 +/- ##
=========================================
Coverage 11.76% 11.77%
- Complexity 7661 7665 +4
=========================================
Files 2503 2503
Lines 245958 245950 -8
Branches 38374 38378 +4
=========================================
+ Hits 28946 28962 +16
+ Misses 213248 213222 -26
- Partials 3764 3766 +2
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...src/main/java/com/cloud/upgrade/GuestOsMapper.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL0d1ZXN0T3NNYXBwZXIuamF2YQ==) | `5.37% <0.00%> (-0.12%)` | :arrow_down: |
| [...ava/com/cloud/upgrade/dao/Upgrade41400to41500.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE0MDB0bzQxNTAwLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ava/com/cloud/upgrade/dao/Upgrade41500to41510.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE1MDB0bzQxNTEwLmphdmE=) | `2.12% <ø> (+0.75%)` | :arrow_up: |
| [...ava/com/cloud/upgrade/dao/Upgrade41510to41520.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE1MTB0bzQxNTIwLmphdmE=) | `12.50% <ø> (-1.79%)` | :arrow_down: |
| [...ava/com/cloud/upgrade/dao/Upgrade41520to41600.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE1MjB0bzQxNjAwLmphdmE=) | `6.45% <ø> (-1.02%)` | :arrow_down: |
| [...ava/com/cloud/upgrade/dao/Upgrade41600to41610.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE2MDB0bzQxNjEwLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ava/com/cloud/upgrade/dao/Upgrade41720to41800.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE3MjB0bzQxODAwLmphdmE=) | `0.81% <0.38%> (-1.07%)` | :arrow_down: |
| [...m/resource/wrapper/LibvirtReadyCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0UmVhZHlDb21tYW5kV3JhcHBlci5qYXZh) | `61.53% <0.00%> (-11.19%)` | :arrow_down: |
| [...bernetes/cluster/KubernetesClusterManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9pbnRlZ3JhdGlvbnMva3ViZXJuZXRlcy1zZXJ2aWNlL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2t1YmVybmV0ZXMvY2x1c3Rlci9LdWJlcm5ldGVzQ2x1c3Rlck1hbmFnZXJJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ervisor/kvm/resource/LibvirtComputingResource.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbXB1dGluZ1Jlc291cmNlLmphdmE=) | `18.62% <0.00%> (+0.27%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1383788549
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1386805275
@nvazquez @weizhouapache I added some test descriptions to the PR. Can you re-view?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1387374093
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7095)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7095&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7095&resolved=false&types=SECURITY_HOTSPOT) [72 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7095&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=CODE_SMELL) [39 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_coverage&view=list) [0.3% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_duplicated_lines_density&view=list) [88.6% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1396865838
> LGTM @DaanHoogland would we need to do that with every release?
Basically, no. Only because the mapping code was broken between 4.16.1 and 4.18 we need to redo the mapping in 4.18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1396870521
> @weizhouapache should I rebase on 4.17?
it will be complicated ...
you need to
(1) add upgrade path 4.17.2.0->4.17.3.0
(2) move everything to Upgrade41720to41730.java
and
what if there is not 4.17.3.0 release ?
what if 4.17.3.0 is released after 4.18.0.0, can upgrade from 4.17.3.0 to 4.18.0.0 ?
we may need to keep the codes in both files: Upgrade41720to41730.java and Upgrade41720to41800.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1397031867
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7095)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7095&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7095&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7095&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=CODE_SMELL) [36 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_coverage&view=list) [0.3% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_duplicated_lines_density&view=list) [88.7% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1654849738
@BryanMLima
yes, I have noticed it.
The method `addGuestOsAndHypervisorMappings` used in this PR will add a new guest OS (even it already exists) and then add guest os mappings.
I have created an issue to track it: #7783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1655190491
@weizhouapache @BryanMLima , seems like we need;
1. a reconsiliation method (merging duplicates)
2. an extra check in `addGuestOsAndHypervisorMappings` to make sure such situations don't arise again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] BryanMLima commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by "BryanMLima (via GitHub)" <gi...@apache.org>.
BryanMLima commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1609903591
Hey @DaanHoogland, I know it has been a while, but did you check if the Guest OS types were duplicate after this change? I have some environments that were recently updated to the `4.18` from the `4.16` and there are 43 duplicate Guest OS types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1383885690
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7095)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7095&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7095&resolved=false&types=SECURITY_HOTSPOT) [13 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7095&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=CODE_SMELL) [43 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7095&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_coverage&view=list) [0.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_duplicated_lines_density&view=list) [84.4% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7095&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1383872473
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1396757072
LGTM @DaanHoogland would we need to do that with every release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1382247322
it seems some codes in Upgrade41400to41500 needs to be moved as well.
```
$ grep -rl addGuestOsAndHypervisorMappings
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41500to41510.java
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41400to41500.java
engine/schema/src/main/java/com/cloud/upgrade/GuestOsMapper.java
$ grep -rl updateGuestOsNameFromMapping
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41500to41510.java
engine/schema/src/main/java/com/cloud/upgrade/GuestOsMapper.java
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1384030720
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1384027841
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1383681533
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1383712427
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
nvazquez commented on code in PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#discussion_r1071423150
##########
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41500to41510.java:
##########
@@ -69,8 +66,6 @@ public InputStream[] getPrepareScripts() {
@Override
public void performDataMigration(Connection conn) {
- correctGuestOsNames(conn);
- updateGuestOsMappings(conn);
Review Comment:
I'm not sure about these schema changes, what would happen to templates/VMs created from existing guest OS on previous versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1387291859
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1398174882
@vladimirpetrov a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1387380323
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1383682737
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1383688379
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1383712779
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#discussion_r1070593253
##########
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41500to41510.java:
##########
@@ -250,130 +249,6 @@ private void correctGuestOsNames(final Connection conn) {
guestOsMapper.updateGuestOsNameFromMapping("OpenSUSE Linux (32 bit)", mapping);
}
Review Comment:
@weizhouapache , your comment in https://github.com/apache/cloudstack/pull/7095#issuecomment-1382247322 means that also this method must be moved? It contains a call to `updateGuestOsNameFromMapping()` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org