You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "shahar1 (via GitHub)" <gi...@apache.org> on 2026/09/12 09:05:53 UTC

Re: [PR] Add more template fields to Create Batch Vertex AI Job Operator to support bq, gcs templating [airflow]

shahar1 commented on code in PR #70679:
URL: https://github.com/apache/airflow/pull/70679#discussion_r3995729626


##########
providers/google/src/airflow/providers/google/cloud/operators/vertex_ai/batch_prediction_job.py:
##########
@@ -159,7 +159,18 @@ class CreateBatchPredictionJobOperator(GoogleCloudBaseOperator):
     :param poll_interval: Interval size which defines how often job status is checked in deferrable mode.
     """
 
-    template_fields = ("region", "project_id", "model_name", "impersonation_chain", "job_display_name")
+    template_fields = (
+        "region",
+        "project_id",
+        "model_name",
+        "impersonation_chain",
+        "job_display_name",
+        "gcs_source",
+        "bigquery_source",
+        "gcs_destination_prefix",
+        "gcs_destination_prefix",

Review Comment:
   Apologies for the delay, and thanks for the detailed answer!
   I'm satisfied with your current explanation. The implications are mainly regaulations around what you can do with template fields in the constructor - once a field is templated, you cannot make any validations for its value in the operator's constructor. 
   In this case it should be safe, so it's a LGTM from me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org