[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4788: Removed unused dependencies, migrated angular from bower to npm

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #4788:
URL: https://github.com/apache/trafficcontrol/pull/4788#discussion_r441044060



##########
File path: traffic_portal/bower.json
##########
@@ -1,23 +1,17 @@
 {
     "name": "traffic_portal",
     "dependencies": {
-        "angular": "1.7.8",
-        "angular-animate": "1.7.8",
         "angular-resource": "1.7.8",

Review comment:
       Not all of "the angular* deps" can be moved over so trivially. Particularly, the bootstrap stuff doesn't load properly when included with browserify from npm. I don't know why, but it might be related to the fact that the version we use from bower is unavailable in npm. Also note, though, that neither available versions are supported, neither package manager offers supported versions, and the version we use is two major versions behind what's current.
   
   With all that in mind I was hoping to just remove angular-bootstrap* entirely, especially if it's only used for the table context menus, since the new ag-grid tables won't use angular-bootstrap-contextmenu.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org