You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "dkranchii (via GitHub)" <gi...@apache.org> on 2026/08/22 20:52:53 UTC
[PR] Core: Extend TestRemoveSnapshots parameterization to V3 [iceberg]
dkranchii opened a new pull request, #17772:
URL: https://github.com/apache/iceberg/pull/17772
## Summary
Extend `TestRemoveSnapshots` to run every test against format version 3 in addition to V1 and V2, and make `testExpireWithDeleteFiles` version-agnostic so it exercises both V2 position-delete parquet files and V3 deletion vectors.
## Motivation
Follow-up to reviewer feedback on #17745 asking for expanded V3 coverage in `TestRemoveSnapshots`. V3 has been the default table format for new writes in recent releases but the snapshot-expiration test class only exercised V1 and V2. This closes that gap for the whole class, not just the delete-file test.
## Changes
- `@Parameters` matrix gains `{3, true}` and `{3, false}` entries, so every `@TestTemplate` in the class runs against V3 for both the incremental and reachable cleanup strategies.
- `testExpireWithDeleteFiles` now uses the existing `fileADeletes()` / `fileBDeletes()` helpers from `TestBase` (which return position deletes for V2 and DVs for V3) instead of hardcoded `FILE_A_DELETES` / `FILE_B_DELETES`. Version guard widened from `isEqualTo(2)` to `isIn(2, 3)`.
V1 has no delete files and V4+ folds delete entries into the root manifest, so V2 and V3 remain the only versions that carry standalone delete manifests.
## Test plan
- [x] `./gradlew :iceberg-core:test --tests "org.apache.iceberg.TestRemoveSnapshots"` passes for all six parameter combinations (V1/V2/V3 × incremental/reachable).
---
**AI Disclosure**
- Platform/Tool: Cursor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Extend TestRemoveSnapshots parameterization to V3 [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17772:
URL: https://github.com/apache/iceberg/pull/17772#issuecomment-5805209451
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Extend TestRemoveSnapshots parameterization to V3 [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #17772: Core: Extend TestRemoveSnapshots parameterization to V3
URL: https://github.com/apache/iceberg/pull/17772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Extend TestRemoveSnapshots parameterization to V3 [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17772:
URL: https://github.com/apache/iceberg/pull/17772#issuecomment-5922286682
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Extend TestRemoveSnapshots parameterization to V3 [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #17772:
URL: https://github.com/apache/iceberg/pull/17772#issuecomment-5385866812
LGTM, thank you @dkranchii!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org