You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@commons.apache.org by gg...@apache.org on 2017/11/27 19:17:27 UTC

svn commit: r1816497 - /commons/proper/bcel/trunk/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java

Author: ggregory
Date: Mon Nov 27 19:17:27 2017
New Revision: 1816497

URL: http://svn.apache.org/viewvc?rev=1816497&view=rev
Log:
Clean ups: use final.

Modified:
    commons/proper/bcel/trunk/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java

Modified: commons/proper/bcel/trunk/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java?rev=1816497&r1=1816496&r2=1816497&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java (original)
+++ commons/proper/bcel/trunk/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java Mon Nov 27 19:17:27 2017
@@ -74,7 +74,7 @@ public class JDKGenericDumpTestCase {
     }
 
     private static Set<String> findJavaHomesOnWindows() {
-        Set<String> javaHomes = new HashSet<>();
+        final Set<String> javaHomes = new HashSet<>();
         addAllJavaHomesOnWindows(KEY_JRE, javaHomes);
         addAllJavaHomesOnWindows(KEY_JRE_9, javaHomes);
         addAllJavaHomesOnWindows(KEY_JDK, javaHomes);
@@ -82,11 +82,11 @@ public class JDKGenericDumpTestCase {
         return javaHomes;
     }
 
-    private static void addAllJavaHomesOnWindows(final String keyJre, Set<String> javaHomes) {
+    private static void addAllJavaHomesOnWindows(final String keyJre, final Set<String> javaHomes) {
         javaHomes.addAll(findJavaHomesOnWindows(keyJre, Advapi32Util.registryGetKeys(HKEY_LOCAL_MACHINE, keyJre)));
     }
 
-    private static Set<String> findJavaHomesOnWindows(String keyJavaHome, final String[] keys) {
+    private static Set<String> findJavaHomesOnWindows(final String keyJavaHome, final String[] keys) {
         final Set<String> javaHomes = new HashSet<>(keys.length);
         for (final String key : keys) {
             if (Advapi32Util.registryKeyExists(HKEY_LOCAL_MACHINE, keyJavaHome + "\\" + key)) {