You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/05/05 05:29:48 UTC

[GitHub] [incubator-tvm] ANSHUMAN87 edited a comment on pull request #5510: [FRONTEND][TFLite] Fully connected op conversion made in sync with TFLite

ANSHUMAN87 edited a comment on pull request #5510:
URL: https://github.com/apache/incubator-tvm/pull/5510#issuecomment-623859989


   > Minor nits, A better commit message would be to refer to handling batch matmul in fully connected op rather than what it stands.
   > 
   > Isn't there a need for Quantized inputs testing here ?
   
   @u99127 : Thanks for your comments! Just for your info, TFLite converter has multiple limitations in terms of various input types supported, so it is not possible always to add all the cases. 
   I had already tried for it, but converter has errors. Also it does not support N-dim.
   
   About the commit, actually the changes are quite unrelated to batch matmul, it is just that open up the issue in implementation. So IMO the commit message looks ok to me. Please let me know if you think otherwise. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org