You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/14 14:39:01 UTC
[GitHub] [incubator-nuttx] daniel-p-carvalho opened a new pull request #98:
Add low level operations to STM32L4 PWM driver.
daniel-p-carvalho opened a new pull request #98: Add low level operations to STM32L4 PWM driver.
URL: https://github.com/apache/incubator-nuttx/pull/98
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis merged pull request #98: Add low level
operations to STM32L4 PWM driver.
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #98: Add low level operations to STM32L4 PWM driver.
URL: https://github.com/apache/incubator-nuttx/pull/98
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis commented on issue #98: Add low level
operations to STM32L4 PWM driver.
Posted by GitBox <gi...@apache.org>.
acassis commented on issue #98: Add low level operations to STM32L4 PWM driver.
URL: https://github.com/apache/incubator-nuttx/pull/98#issuecomment-574234993
Worked like a charm! Now I just need to run: "git newpr pr98" and everything is done:
$ cat /usr/bin/git-newpr
#!/bin/bash
source "$(git --exec-path)/git-sh-setup"
function _newpr() {
git pull --rebase
git branch $1
git checkout $1
}
_newpr $1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis commented on issue #98: Add low level
operations to STM32L4 PWM driver.
Posted by GitBox <gi...@apache.org>.
acassis commented on issue #98: Add low level operations to STM32L4 PWM driver.
URL: https://github.com/apache/incubator-nuttx/pull/98#issuecomment-574225083
Mmm, I can create my own "git branch" command, very interesting: https://coderwall.com/p/bt93ia/extend-git-with-custom-commands
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #98: Add low level
operations to STM32L4 PWM driver.
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #98: Add low level operations to STM32L4 PWM driver.
URL: https://github.com/apache/incubator-nuttx/pull/98#issuecomment-574219467
@acassis now I saw that you did it manually
Thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis commented on issue #98: Add low level
operations to STM32L4 PWM driver.
Posted by GitBox <gi...@apache.org>.
acassis commented on issue #98: Add low level operations to STM32L4 PWM driver.
URL: https://github.com/apache/incubator-nuttx/pull/98#issuecomment-574221261
You are welcome! I need a "pre-branch" hook, but AFAIK it doesn't exist: https://stackoverflow.com/questions/26745194/git-pre-branch-hook-possible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #98: Add low level
operations to STM32L4 PWM driver.
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #98: Add low level operations to STM32L4 PWM driver.
URL: https://github.com/apache/incubator-nuttx/pull/98#issuecomment-574209661
you should rebase your commits to avoid this kind of master merge!
Merge remote-tracking branch 'upstream/master'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis commented on issue #98: Add low level
operations to STM32L4 PWM driver.
Posted by GitBox <gi...@apache.org>.
acassis commented on issue #98: Add low level operations to STM32L4 PWM driver.
URL: https://github.com/apache/incubator-nuttx/pull/98#issuecomment-574215884
Hi Alin, normally I do: git pull --rebase, but I did it after the pr98 creating and then merged pr98 with master to keep it in sync. It generated an avalanche of previous patches, but the final commit was fine. I just spent more time fixing the message. I should love to have some trigger that force me to do a rebase before creating a branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services