You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/12/08 19:21:01 UTC
[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #3374: ARTEMIS-3024 Expiry or DLQ Retry not working with AMQP
clebertsuconic opened a new pull request #3374:
URL: https://github.com/apache/activemq-artemis/pull/3374
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3374: ARTEMIS-3024 Expiry or DLQ Retry not working with AMQP
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3374:
URL: https://github.com/apache/activemq-artemis/pull/3374#discussion_r538862515
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Queue.java
##########
@@ -361,6 +361,10 @@ int moveReferences(int flushLimit,
int retryMessages(Filter filter) throws Exception;
+ default int retryMessages(Filter filter, Integer expectedHits) throws Exception {
Review comment:
Why default method? Its been implemented in queueimpl
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3374: ARTEMIS-3024 Expiry or DLQ Retry not working with AMQP
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3374:
URL: https://github.com/apache/activemq-artemis/pull/3374#discussion_r538914695
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Queue.java
##########
@@ -361,6 +361,10 @@ int moveReferences(int flushLimit,
int retryMessages(Filter filter) throws Exception;
+ default int retryMessages(Filter filter, Integer expectedHits) throws Exception {
Review comment:
@michaelandrepearce I could go without the default.. but having the default here minimized the number of changes on Fakes.. etc... It was just for simplicity and minimize the number of lines changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit merged pull request #3374: ARTEMIS-3024 Expiry or DLQ Retry not working with AMQP
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #3374:
URL: https://github.com/apache/activemq-artemis/pull/3374
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3374: ARTEMIS-3024 Expiry or DLQ Retry not working with AMQP
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3374:
URL: https://github.com/apache/activemq-artemis/pull/3374#discussion_r538893095
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -2140,6 +2140,7 @@ private int iterQueue(final int flushLimit,
QueueIterateAction messageAction) throws Exception {
int count = 0;
int txCount = 0;
+ Integer expectedHits = messageAction.expectedHits();
Review comment:
QueueControl.expire with a messageID will only expire a single record, however the iteration will go until the end. it's sort of an optimization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3374: ARTEMIS-3024 Expiry or DLQ Retry not working with AMQP
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3374:
URL: https://github.com/apache/activemq-artemis/pull/3374#discussion_r538892829
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Queue.java
##########
@@ -361,6 +361,10 @@ int moveReferences(int flushLimit,
int retryMessages(Filter filter) throws Exception;
+ default int retryMessages(Filter filter, Integer expectedHits) throws Exception {
Review comment:
there are a bunch of Fakes that don't require implementing anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3374: ARTEMIS-3024 Expiry or DLQ Retry not working with AMQP
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3374:
URL: https://github.com/apache/activemq-artemis/pull/3374#discussion_r538861980
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -2140,6 +2140,7 @@ private int iterQueue(final int flushLimit,
QueueIterateAction messageAction) throws Exception {
int count = 0;
int txCount = 0;
+ Integer expectedHits = messageAction.expectedHits();
Review comment:
Whats the purpose of this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org