You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Jeremy Daggett <no...@github.com> on 2014/09/16 22:20:47 UTC
[jclouds] Add assertj-core and assertj-guava dependencies to project
pom (#522)
This change will also be backported to the 1.8.x branch in another PR.
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds assertj
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/522
-- Commit Summary --
* Add assertj-core and assertj-guava dependencies to project pom
-- File Changes --
M project/pom.xml (22)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/522.patch
https://github.com/jclouds/jclouds/pull/522.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/522
Re: [jclouds] Add assertj-core and assertj-guava dependencies to
project pom (#522)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #87](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/87/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/522#issuecomment-55807601
Re: [jclouds] Add assertj-core and assertj-guava dependencies to
project pom (#522)
Posted by Jeremy Daggett <no...@github.com>.
> @@ -310,6 +322,16 @@
> <artifactId>core.incubator</artifactId>
> <optional>true</optional>
> </dependency>
> + <dependency>
> + <groupId>org.assertj</groupId>
> + <artifactId>assertj-core</artifactId>
> + <scope>test</scope>
> + </dependency>
> + <dependency>
> + <groupId>org.assertj</groupId>
> + <artifactId>assertj-guava</artifactId>
> + <scope>test</scope>
> + </dependency>
Yes, I believe we do since the other core test libraries are configured this way. Does that make sense?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/522/files#r17633088
Re: [jclouds] Add assertj-core and assertj-guava dependencies to
project pom (#522)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1176](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1176/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/522#issuecomment-55816649
Re: [jclouds] Add assertj-core and assertj-guava dependencies to
project pom (#522)
Posted by Jeremy Daggett <no...@github.com>.
Closed #522.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/522#event-166930245
Re: [jclouds] Add assertj-core and assertj-guava dependencies to
project pom (#522)
Posted by Andrew Phillips <no...@github.com>.
> @@ -310,6 +322,16 @@
> <artifactId>core.incubator</artifactId>
> <optional>true</optional>
> </dependency>
> + <dependency>
> + <groupId>org.assertj</groupId>
> + <artifactId>assertj-core</artifactId>
> + <scope>test</scope>
> + </dependency>
> + <dependency>
> + <groupId>org.assertj</groupId>
> + <artifactId>assertj-guava</artifactId>
> + <scope>test</scope>
> + </dependency>
This adds it as a default dep, rather than just configuring the versions for where they are needed. Do we want this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/522/files#r17632131
Re: [jclouds] Add assertj-core and assertj-guava dependencies to
project pom (#522)
Posted by Jeremy Daggett <no...@github.com>.
Pushed to master 0ac7dfd and 1.8.x 593fbac
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/522#issuecomment-55975487
Re: [jclouds] Add assertj-core and assertj-guava dependencies to
project pom (#522)
Posted by Andrew Phillips <no...@github.com>.
> @@ -310,6 +322,16 @@
> <artifactId>core.incubator</artifactId>
> <optional>true</optional>
> </dependency>
> + <dependency>
> + <groupId>org.assertj</groupId>
> + <artifactId>assertj-core</artifactId>
> + <scope>test</scope>
> + </dependency>
> + <dependency>
> + <groupId>org.assertj</groupId>
> + <artifactId>assertj-guava</artifactId>
> + <scope>test</scope>
> + </dependency>
> Does that make sense?
Yes, thanks.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/522/files#r17678370