You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/28 02:08:38 UTC

[GitHub] [pulsar] tjiuming commented on a diff in pull request #17852: [branch-2.9] Group prometheus metrics.

tjiuming commented on code in PR #17852:
URL: https://github.com/apache/pulsar/pull/17852#discussion_r981874488


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java:
##########
@@ -129,6 +135,8 @@ public static void generate(PulsarService pulsar, boolean includeTopicMetrics, b
             }
             out.write(buf.array(), buf.arrayOffset(), buf.readableBytes());
         } finally {
+            //release all the metrics buffers
+            metricStreams.releaseAll();

Review Comment:
   @codelipenghui No, this check is for https://github.com/apache/pulsar/pull/14453, the feature didn't check-pick to 2.9



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org