You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/11/24 02:24:20 UTC
Re: Review Request 38338: Enhanced option for Docker cli volume
plugin.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38338/#review107695
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Oct. 3, 2015, 3:55 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38338/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 3:55 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3392
> https://issues.apache.org/jira/browse/MESOS-3392
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enhanced option for Docker cli volume plugin.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999
> src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7
>
> Diff: https://reviews.apache.org/r/38338/diff/
>
>
> Testing
> -------
>
> # When use volume-driver
> ```
> I1003 23:49:41.986047 11268 docker.cpp:571] Running docker -H unix:///var/run/docker.sock run -e MESOS_SANDBOX=/mnt/mesos/sandbox -e MESOS_CONTAINER_NAME=mesos-docker-test -v src:target:rw -v /tmp/DockerTest_ROOT_DOCKER_volume_driver_D3Fxye:/mnt/mesos/sandbox --volume-driver=flocker --net host --entrypoint /bin/sh --name mesos-docker-test busybox -c sleep 120
> ```
> Could see `-v src:target`
>
> # When don't use volume-driver
> ```
> 1003 23:53:48.028715 12125 docker.cpp:571] Running docker -H unix:///var/run/docker.sock run -e MESOS_SANDBOX=/mnt/mesos/sandbox -e MESOS_CONTAINER_NAME=mesos-docker-test -v /tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt/src:target:rw -v /tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt:/mnt/mesos/sandbox --net host --entrypoint /bin/sh --name mesos-docker-test busybox -c sleep 120
> ```
> Could see `-v /tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt/src:target:rw`
>
>
> Thanks,
>
> haosdent huang
>
>