You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@yetus.apache.org by "Kengo Seki (JIRA)" <ji...@apache.org> on 2015/11/02 06:04:27 UTC

[jira] [Comment Edited] (YETUS-148) Wrong variable name ${TP_SHELL_SCRIPT_DEBUG}

    [ https://issues.apache.org/jira/browse/YETUS-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984747#comment-14984747 ] 

Kengo Seki edited comment on YETUS-148 at 11/2/15 5:03 AM:
-----------------------------------------------------------

Removed unnecessary code. I confirmed that debug is enabled in docker mode as well as non-docker mode if debug option is specified.

{code}
[sekikn@mobile yetus]$ grep TP_SHELL_SCRIPT_DEBUG precommit/test-patch.sh 
[sekikn@mobile yetus]$ precommit/test-patch.sh --basedir=../hadoop --debug --docker --patch-dir=/Users/sekikn/p --project=hadoop --resetrepo HADOOP-12070

(snip)

============================================================================
============================================================================
                          Re-execing under Docker
============================================================================
============================================================================

(snip)

Successfully built e9e51476049a
JAVA_HOME: /Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/Home does not exist. Dockermode: attempting to switch to another.
[Mon Nov  2 05:01:23 UTC 2015 DEBUG]: Stop clock
[Mon Nov  2 05:01:23 UTC 2015 DEBUG]: add_vote_table 0 reexec docker + precommit patch detected.
Running in destructive (--resetrepo) developer mode
[Mon Nov  2 05:01:23 UTC 2015 DEBUG]: Loading user provided plugins from /testptch/patchprocess/precommit/user-plugins
[Mon Nov  2 05:01:23 UTC 2015 DEBUG]: Importing /testptch/patchprocess/precommit/personality/provided.sh

(snip)
{code}


was (Author: sekikn):
Removed unnecessary code. I confirmed that debug is enabled in docker mode as well as non-docker mode if debug option is specified.

> Wrong variable name ${TP_SHELL_SCRIPT_DEBUG}
> --------------------------------------------
>
>                 Key: YETUS-148
>                 URL: https://issues.apache.org/jira/browse/YETUS-148
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Kengo Seki
>            Assignee: Kengo Seki
>         Attachments: YETUS-148.00.patch
>
>
> {code:title=precommit/test-patch.sh}
> 1541     if [[ ${TP_SHELL_SCRIPT_DEBUG} = true ]]; then
> 1542       debugflag="--debug"
> 1543     fi
> {code}
> {code}
> [sekikn@mobile yetus]$ grep -r SHELL_SCRIPT_DEBUG precommit
> precommit/core.d/00-yetuslib.sh:  if [[ "${YETUS_SHELL_SCRIPT_DEBUG}" = true ]]; then
> precommit/core.d/01-common.sh:  YETUS_SHELL_SCRIPT_DEBUG=false
> precommit/core.d/01-common.sh:        YETUS_SHELL_SCRIPT_DEBUG=true
> precommit/test-patch-docker/test-patch-docker.sh:  if [[ "${YETUS_SHELL_SCRIPT_DEBUG}" = true ]]; then
> precommit/test-patch-docker/test-patch-docker.sh:        YETUS_SHELL_SCRIPT_DEBUG=true
> precommit/test-patch.sh:  if [[ "${YETUS_SHELL_SCRIPT_DEBUG}" = true ]]; then
> precommit/test-patch.sh:    if [[ ${TP_SHELL_SCRIPT_DEBUG} = true ]]; then
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)