You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/19 05:55:43 UTC

[GitHub] [calcite] jinxing64 commented on issue #1422: [CALCITE-3300] Add a star identifier as operand to "SqlCountAggFunction" if no operands given while in the method "createCall"

jinxing64 commented on issue #1422: [CALCITE-3300] Add a star identifier as operand to "SqlCountAggFunction" if no operands given while in the method "createCall"
URL: https://github.com/apache/calcite/pull/1422#issuecomment-544105374
 
 
   In current code https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L5132
   `*` is explicitly checked and removed for `count(*)` when converting sql to rel. Shall we just replace `*` with the first column of the child ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services