You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ro...@apache.org on 2016/05/03 02:16:01 UTC
[1/2] incubator-beam git commit: Fix the java doc for Combine.perKey
and ApproximateQuantiles
Repository: incubator-beam
Updated Branches:
refs/heads/master 3ebdf4886 -> 69ec223e5
Fix the java doc for Combine.perKey and ApproximateQuantiles
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/df1d4862
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/df1d4862
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/df1d4862
Branch: refs/heads/master
Commit: df1d48621020443caeb055e7930fcd2e955f0afb
Parents: 3ebdf48
Author: Pei He <pe...@google.com>
Authored: Mon May 2 15:26:39 2016 -0700
Committer: Robert Bradshaw <ro...@google.com>
Committed: Mon May 2 17:09:36 2016 -0700
----------------------------------------------------------------------
.../org/apache/beam/sdk/transforms/ApproximateQuantiles.java | 4 ++--
.../src/main/java/org/apache/beam/sdk/transforms/Combine.java | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/df1d4862/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java
index 66f7a6a..4eb06d2 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java
@@ -74,7 +74,7 @@ public class ApproximateQuantiles {
* {@code numQuantiles-2} intermediate values, and maximum value, in
* sorted order, using the given {@code Comparator} to order values.
* To compute traditional {@code N}-tiles, one should use
- * {@code ApproximateQuantiles.globally(compareFn, N+1)}.
+ * {@code ApproximateQuantiles.globally(N+1, compareFn)}.
*
* <p>If there are fewer input elements than {@code numQuantiles},
* then the result {@code List} will contain all the input elements,
@@ -86,7 +86,7 @@ public class ApproximateQuantiles {
* <pre> {@code
* PCollection<String> pc = ...;
* PCollection<List<String>> quantiles =
- * pc.apply(ApproximateQuantiles.globally(stringCompareFn, 11));
+ * pc.apply(ApproximateQuantiles.globally(11, stringCompareFn));
* } </pre>
*
* @param <T> the type of the elements in the input {@code PCollection}
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/df1d4862/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java
index f3a7c03..8a39c98 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java
@@ -1661,7 +1661,7 @@ public class Combine {
* <pre> {@code
* PCollection<KV<String, Double>> salesRecords = ...;
* PCollection<KV<String, Double>> totalSalesPerPerson =
- * salesRecords.apply(Combine.<String, Double>perKey(
+ * salesRecords.apply(Combine.<String, Double, Double>perKey(
* new Sum.SumDoubleFn()));
* } </pre>
*
[2/2] incubator-beam git commit: Fix the java doc for Combine.perKey
and ApproximateQuantiles
Posted by ro...@apache.org.
Fix the java doc for Combine.perKey and ApproximateQuantiles
This closes #272
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/69ec223e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/69ec223e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/69ec223e
Branch: refs/heads/master
Commit: 69ec223e589147a8decde5c3a10568f5b0c1b5a1
Parents: 3ebdf48 df1d486
Author: Robert Bradshaw <ro...@google.com>
Authored: Mon May 2 17:10:15 2016 -0700
Committer: Robert Bradshaw <ro...@google.com>
Committed: Mon May 2 17:10:15 2016 -0700
----------------------------------------------------------------------
.../org/apache/beam/sdk/transforms/ApproximateQuantiles.java | 4 ++--
.../src/main/java/org/apache/beam/sdk/transforms/Combine.java | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------