You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "mwhipple (via GitHub)" <gi...@apache.org> on 2024/01/27 18:51:19 UTC
[PR] [improve][client] Mention partitioning in failover priorityLevel javaDoc [pulsar]
mwhipple opened a new pull request, #21980:
URL: https://github.com/apache/pulsar/pull/21980
Fixes: #21922
### Motivation
Clarify when priorityLevel is active for failover subscriptions.
### Modifications
Update javaDoc comment to specify paritioned topics and indicate insignificance for non-partitioned.
### Verifying this change
- [X] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
- [X] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][client] Mention partitioning in failover priorityLevel javaDoc [pulsar]
Posted by "mwhipple (via GitHub)" <gi...@apache.org>.
mwhipple commented on code in PR #21980:
URL: https://github.com/apache/pulsar/pull/21980#discussion_r1473362653
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -511,9 +511,9 @@ public interface ConsumerBuilder<T> extends Cloneable {
* Order in which broker dispatches messages to consumers: C1, C2, C3, C1, C4, C5, C4
* </pre>
*
- * <p><b>Failover subscription</b>
- * The broker selects the active consumer for a failover subscription based on consumer's priority-level and
- * lexicographical sorting of consumer name.
+ * <p><b>Failover subscription for partitioned topic</b>
+ * The broker selects the active consumer for a failover subscription for a patitioned topic
Review Comment:
:facepalm: thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][client] Mention partitioning in failover priorityLevel javaDoc [pulsar]
Posted by "mwhipple (via GitHub)" <gi...@apache.org>.
mwhipple commented on PR #21980:
URL: https://github.com/apache/pulsar/pull/21980#issuecomment-1919146715
This seems to be running up against #19307
Java 1.17.0.10 is now available and purportedly fixes the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][client] Mention partitioning in failover priorityLevel javaDoc [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on code in PR #21980:
URL: https://github.com/apache/pulsar/pull/21980#discussion_r1473360634
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -511,9 +511,9 @@ public interface ConsumerBuilder<T> extends Cloneable {
* Order in which broker dispatches messages to consumers: C1, C2, C3, C1, C4, C5, C4
* </pre>
*
- * <p><b>Failover subscription</b>
- * The broker selects the active consumer for a failover subscription based on consumer's priority-level and
- * lexicographical sorting of consumer name.
+ * <p><b>Failover subscription for partitioned topic</b>
+ * The broker selects the active consumer for a failover subscription for a patitioned topic
Review Comment:
```suggestion
* The broker selects the active consumer for a failover subscription for a partitioned topic
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][client] Mention partitioning in failover priorityLevel javaDoc [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #21980:
URL: https://github.com/apache/pulsar/pull/21980#discussion_r1473331611
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -511,9 +511,9 @@ public interface ConsumerBuilder<T> extends Cloneable {
* Order in which broker dispatches messages to consumers: C1, C2, C3, C1, C4, C5, C4
* </pre>
*
- * <p><b>Failover subscription</b>
- * The broker selects the active consumer for a failover subscription based on consumer's priority-level and
- * lexicographical sorting of consumer name.
+ * <p><b>Failover subscription for partitioned topic</b>
+ * The broker selects the active consumer for a failover subscription for a patitioned topic
Review Comment:
```suggestion
* The broker selects the active consumer for a failover subscription for a partitioned topic
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][client] Mention partitioning in failover priorityLevel javaDoc [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #21980:
URL: https://github.com/apache/pulsar/pull/21980#discussion_r1473331611
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -511,9 +511,9 @@ public interface ConsumerBuilder<T> extends Cloneable {
* Order in which broker dispatches messages to consumers: C1, C2, C3, C1, C4, C5, C4
* </pre>
*
- * <p><b>Failover subscription</b>
- * The broker selects the active consumer for a failover subscription based on consumer's priority-level and
- * lexicographical sorting of consumer name.
+ * <p><b>Failover subscription for partitioned topic</b>
+ * The broker selects the active consumer for a failover subscription for a patitioned topic
Review Comment:
```suggestion
* The broker selects the active consumer for a failover subscription for a partitioned topic
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][client] Mention partitioning in failover priorityLevel javaDoc [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #21980:
URL: https://github.com/apache/pulsar/pull/21980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org