You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by rb...@covalent.net on 2000/11/22 00:59:51 UTC
mod_include...again. :-)
Paul,
Please remove any time that you set the value of r->output_filters
directly. No filter should ever try to outguess the core in this
regard. The core inserts a sub-request filter to remove excess EOS
buckets, and your setting the sub-request's output filters to the next
filter in the chain breaks a lot of the code.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: mod_include...again. :-)
Posted by Doug MacEachern <do...@covalent.net>.
> Consider it done. Can I axe the rest of the perl stuff then too?
yup!
Re: mod_include...again. :-)
Posted by "Paul J. Reder" <re...@raleigh.ibm.com>.
Doug MacEachern wrote:
>
> On Tue, 21 Nov 2000, Paul J. Reder wrote:
>
> > By the way, the USE_SFIO, VOIDUSED, and USE_STDIO are things related to the
> > perl extensions (all inside a #ifdef USE_PERL_SSI). I will leave them in there
> > until I have implemented the hash/hook stuff.
>
> feel free to throw that away now. mod_perl-2.0-dev does not support it, i
> had been hoping for a cleaner way. hash/hook stuff sounds great for that.
Consider it done. Can I axe the rest of the perl stuff then too?
--
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it. Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein
Re: mod_include...again. :-)
Posted by Doug MacEachern <do...@covalent.net>.
On Tue, 21 Nov 2000, Paul J. Reder wrote:
> By the way, the USE_SFIO, VOIDUSED, and USE_STDIO are things related to the
> perl extensions (all inside a #ifdef USE_PERL_SSI). I will leave them in there
> until I have implemented the hash/hook stuff.
feel free to throw that away now. mod_perl-2.0-dev does not support it, i
had been hoping for a cleaner way. hash/hook stuff sounds great for that.
Re: mod_include...again. :-)
Posted by "Paul J. Reder" <re...@raleigh.ibm.com>.
rbb@covalent.net wrote:
> Please remove any time that you set the value of r->output_filters
> directly. No filter should ever try to outguess the core in this
> regard. The core inserts a sub-request filter to remove excess EOS
> buckets, and your setting the sub-request's output filters to the next
> filter in the chain breaks a lot of the code.
I assume that you mean the two cases where the code does this:
rr->output_filters = next;
if (ap_run_sub_req(rr)) {
This is another case of "It was there when I got there and I didn't know
it was bad." They are both gone now (the rr->output_filters = next; parts
that is).
I am currently testing my updates and expect a post within an hour or so
(this evening for sure). It will not have the hash/hook stuff.
By the way, the USE_SFIO, VOIDUSED, and USE_STDIO are things related to the
perl extensions (all inside a #ifdef USE_PERL_SSI). I will leave them in there
until I have implemented the hash/hook stuff.
--
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it. Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein