[GitHub] [accumulo] keith-turner commented on pull request #1985: Move Constraints to SPI

[GitBox <gi...@apache.org>]

keith-turner commented on pull request #1985:
URL: https://github.com/apache/accumulo/pull/1985#issuecomment-811147061


   It may make sense to move constraints package into the public API like like was done with iterators.  Thinking this for the following reasons.
   
     * All the types in the package could easily be moved to the public API
     * Except for KeyExtent I think the types referenced by the package are in the public api in the data and security packages.
     * The interfaces have been stable since at least 2012 (except for the addition of a single method I think), but probably since Accumulo was open sourced.
     * Users have been encouraged to use the interfaces by Documentation for a very long time https://accumulo.apache.org/docs/2.x/getting-started/table_configuration#constraints https://accumulo.apache.org/1.10/accumulo_user_manual.html#_constraints
     * Like iterators these classes deal with user data, for me when something has that purpose I think public API.
     * The method that returns a KeyExtent could be deprecated for removal for now if the package is promoted to public API.
     * There is a shell command for dealing with constraints


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org