You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/24 06:48:04 UTC

[GitHub] [flink] rmetzger edited a comment on pull request #15348: [FLINK-21844][runtime] Do not auto-configure maxParallelism in REACTIVE scheduling mode

rmetzger edited a comment on pull request #15348:
URL: https://github.com/apache/flink/pull/15348#issuecomment-805547768


   I made a pass over the code, but didn't spot anything. I validated that the error message if one forgets to set a maxParallelism in the tests is understandable.
   
   Overall, I'm not sure if the place where we set the default now is good, or if there's a better place (that wouldn't require setting the maxParallelism in tests not going through the scheduler). But I couldn't come up with a better place.
   I'm curious what @zentol things about this and the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org